Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-96121: Merge sqlite3.Row examples#96122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedAug 19, 2022•
edited by bedevere-bot
Loading

  • Merge sqlite3.Row examples
  • Remove the how-to and incorporate it into the reference

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems like@ezio-melotti already addressed everything important, so just a couple trivial nits (I was slightly confused by the description ofkeys(), but that seems a bit out of scope here.

erlend-aasland reacted with thumbs up emoji
Erlend E. Aaslandand others added2 commitsAugust 20, 2022 09:25
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@CAM-Gerlach
Copy link
Member

GitHub screwed up my review again, though I think I at least know what it was this time—simply replying to another review comment in one tab with theComments view open with another in theFiles view, which is rather silly.

@erlend-aasland
Copy link
ContributorAuthor

(I was slightly confused by the description ofkeys(), but that seems a bit out of scope here.

The second sentence, right? Yes, it reads ... a bit awkward.

CAM-Gerlach reacted with thumbs up emoji

@CAM-Gerlach
Copy link
Member

The second sentence, right? Yes, it reads ... a bit awkward.

Yup, in particular I didn't understand why it would only be so "Immediately after a query".

@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aaslanderlend-aasland deleted the sqlite-docs/row-example branchAugust 22, 2022 08:03
@bedevere-bot
Copy link

GH-96166 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelAug 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 22, 2022
…pythonGH-96122)Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>(cherry picked from commit18b1782)Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 22, 2022
…pythonGH-96122)Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>(cherry picked from commit18b1782)Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

GH-96167 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelAug 22, 2022
miss-islington added a commit that referenced this pull requestAug 22, 2022
…6122)Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>(cherry picked from commit18b1782)Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this pull requestAug 22, 2022
…6122)Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>(cherry picked from commit18b1782)Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ezio-melottiezio-melottiezio-melotti left review comments

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Merge sqlite3.Row (reference) example with the Row How-to Guide

5 participants

@erlend-aasland@CAM-Gerlach@miss-islington@bedevere-bot@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp