Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-95975: Move except/*/finally ref labels to more precise locations#95976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

CAM-Gerlach
Copy link
Member

@CAM-GerlachCAM-Gerlach commentedAug 14, 2022•
edited by bedevere-bot
Loading

As originally discussed in#95937 and documented in#95975 , the ref target labels for theexcept,except* andfinally keywords are not very precise. Therefore, this moves them to more appropriate locations.

Additionally, since it is evidently required to ensure:keyword: keeps working, the section already organized by clause and it would aid navigation for readers on that page as well (since the section is quite long as it is), it adds subsections for each clause type.

finally, it moves the short paragraph directing the reader to other resources to the end of the top-level introduction section, rather than the end of thefinally subsection, as it is notfinally-specific (whereas theversionchangedafter itis), and is also easier for readers to to find.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@CAM-Gerlach
Copy link
MemberAuthor

@ezio-melotti sorry, forgot to re-request review since you'd already approved it

@CAM-Gerlach
Copy link
MemberAuthor

CAM-Gerlach commentedOct 2, 2022•
edited
Loading

Hey@ezio-melotti any blockers to getting this merged so we can hopefully get it into 3.11 (@pablogsal ?) Also, looks like more possible approval spam...

ezio-melotti reacted with thumbs up emoji

@ezio-melottiezio-melotti merged commitdcc8233 intopython:mainOct 2, 2022
@miss-islington
Copy link
Contributor

Thanks@CAM-Gerlach for the PR, and@ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-97722 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelOct 2, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 2, 2022
…tions (pythonGH-95976)*pythongh-95975: Move except/*/finally ref labels to more precise locations* Add section headers to fix :keyword: role and aid navigation* Move see also to the introduction rather than a particular subsection* Fix other minor Sphinx syntax issues with exceptCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>* Suppress redundant link to same section for except too* Don't link try/except/else/finally keywords if in the same section* Format try/except/finally as keywords in modified sectionsCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>(cherry picked from commitdcc8233)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull requestOct 2, 2022
…H-95976)*gh-95975: Move except/*/finally ref labels to more precise locations* Add section headers to fix :keyword: role and aid navigation* Move see also to the introduction rather than a particular subsection* Fix other minor Sphinx syntax issues with exceptCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>* Suppress redundant link to same section for except too* Don't link try/except/else/finally keywords if in the same section* Format try/except/finally as keywords in modified sectionsCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>(cherry picked from commitdcc8233)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull requestOct 2, 2022
…tions (python#95976)*pythongh-95975: Move except/*/finally ref labels to more precise locations* Add section headers to fix :keyword: role and aid navigation* Move see also to the introduction rather than a particular subsection* Fix other minor Sphinx syntax issues with exceptCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>* Suppress redundant link to same section for except too* Don't link try/except/else/finally keywords if in the same section* Format try/except/finally as keywords in modified sectionsCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull requestOct 3, 2022
* main: (2069 commits)pythongh-96512: Move int_max_str_digits setting to PyConfig (python#96944)pythongh-94808: Coverage: Check picklablability of calliter (python#95923)pythongh-94808: Add test coverage for PyObject_HasAttrString (python#96627)pythongh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (python#97765)  Fix typos in `bltinmodule.c`. (pythonGH-97766)pythongh-94808: `_PyLineTable_StartsLine` was not used (pythonGH-96609)pythongh-97681: Remove Tools/demo/ directory (python#97682)  Fix typo in unittest docs (python#97742)pythongh-97728: Argument Clinic: Fix uninitialized variable in the Py_UNICODE converter (pythonGH-97729)pythongh-95913: Fix PEP number in PEP 678 What's New ref label (python#97739)pythongh-95913: Copyedit/improve New Modules What's New section (python#97721)pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python#97741)pythongh-96819: multiprocessing.resource_tracker: check if length of pipe write <= 512 (python#96890)pythongh-97706: multiprocessing tests: Delete unused variable `rand` (python#97707)pythonGH-85447: Clarify docs about awaiting future multiple times (python#97738)  [docs] Update logging cookbook with recipe for using a logger like an output… (pythonGH-97730)pythongh-97607: Fix content parsing in the impl-detail reST directive (python#97652)pythongh-95975: Move except/*/finally ref labels to more precise locations (python#95976)pythongh-97591: In `Exception.__setstate__()` acquire strong references before calling `tp_hash` slot (python#97700)pythongh-95588: Drop the safety claim from `ast.literal_eval` docs. (python#95919)  ...
pablogsal pushed a commit that referenced this pull requestOct 22, 2022
…H-95976)*gh-95975: Move except/*/finally ref labels to more precise locations* Add section headers to fix :keyword: role and aid navigation* Move see also to the introduction rather than a particular subsection* Fix other minor Sphinx syntax issues with exceptCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>* Suppress redundant link to same section for except too* Don't link try/except/else/finally keywords if in the same section* Format try/except/finally as keywords in modified sectionsCo-authored-by: Ezio Melotti <ezio.melotti@gmail.com>(cherry picked from commitdcc8233)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ezio-melottiezio-melottiezio-melotti approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@CAM-Gerlach@miss-islington@bedevere-bot@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp