Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-95605: Fixfloat(s) error message whens contains only whitespace#95665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@mdickinson
Copy link
Member

@mdickinsonmdickinson commentedAug 4, 2022•
edited by bedevere-bot
Loading

This PR fixes the error message fromfloat(s) in the case wheres contains only whitespace.

Closes#95605.

@mdickinson
Copy link
MemberAuthor

mdickinson commentedAug 9, 2022•
edited
Loading

@ericvsmith Would you have bandwidth for review, by any chance? I think it's a fairly simple fix. (Indeed, I was sorely tempted to try a more complicated refactoring and cleanup, but I think that's best left for 3.12.)

Copy link
Member

@ericvsmithericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks correct to me. Thanks,@mdickinson!

@mdickinson
Copy link
MemberAuthor

Thanks,@ericvsmith!

@mdickinsonmdickinson merged commit97e9cfa intopython:mainAug 10, 2022
@miss-islington
Copy link
Contributor

Thanks@mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-95858 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelAug 10, 2022
@bedevere-bot
Copy link

GH-95859 is a backport of this pull request to the3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 10, 2022
…hitespace (pythonGH-95665)This PR fixes the error message from float(s) in the case where s contains only whitespace.(cherry picked from commit97e9cfa)Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 10, 2022
…hitespace (pythonGH-95665)This PR fixes the error message from float(s) in the case where s contains only whitespace.(cherry picked from commit97e9cfa)Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
mdickinson added a commit that referenced this pull requestAug 10, 2022
…ace (GH-95665) (GH-95859)This PR fixes the error message from float(s) in the case where s contains only whitespace.(cherry picked from commit97e9cfa)Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
mdickinson added a commit that referenced this pull requestAug 11, 2022
…ace (GH-95665) (GH-95858)This PR fixes the error message from float(s) in the case where s contains only whitespace.(cherry picked from commit97e9cfa)Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ericvsmithericvsmithericvsmith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The ValueError for converting an all-whitespace string to a float misleadingly displays it as the empty string

4 participants

@mdickinson@miss-islington@bedevere-bot@ericvsmith
[8]ページ先頭
©2009-2025 Movatter.jp