Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-92678: Fix tp_dictoffset inheritance.#95596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commentedAug 3, 2022•
edited by bedevere-bot
Loading

Restores the 3.10 behavior for inheritingtp_dictoffset involving multiple inheritance of C extension classes.

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can't check there aren't more edge cases, but this is an improvement, and should address the pybind11 issue.

@markshannon
Copy link
MemberAuthor

I can't check there aren't more edge cases

Any ideas? I'd be very happy to add more tests

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

mostly LGTM

The new test seems fine, but I didn't look at it thoroughly. I left one comment (about a second case forweaklistoffset) that should definitely be address one way or another.

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@markshannonmarkshannon added the needs backport to 3.11only security fixes labelAug 3, 2022
@markshannonmarkshannon merged commit906e450 intopython:mainAug 3, 2022
@miss-islington
Copy link
Contributor

Thanks@markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@markshannon, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 906e4509328917fe9951f85457897f6a841e0529 3.11

markshannon added a commit to faster-cpython/cpython that referenced this pull requestAug 3, 2022
* Add test for inheriting explicit __dict__ and weakref.* Restore 3.10 behavior for multiple inheritance of C extension classes that store their dictionary at the end of the struct.
@vstinner
Copy link
Member

I cannot review the implementation, but thanks for adding tests!#92678 looked complicated and serious. Thanks for fixing it ;-)

markshannon added a commit that referenced this pull requestAug 4, 2022
* Add test for inheriting explicit __dict__ and weakref.* Restore 3.10 behavior for multiple inheritance of C extension classes that store their dictionary at the end of the struct.
@markshannonmarkshannon deleted the fix-dictoffset-inheritance branchSeptember 26, 2023 12:55
@terryjreedyterryjreedy changed the titleGH-92678: Fix tp_dictoffset inheritance.gh-92678: Fix tp_dictoffset inheritance.Feb 18, 2025
@terryjreedy
Copy link
Member

PR#95604 is merged 3.11 backport.

@terryjreedyterryjreedy removed the needs backport to 3.11only security fixes labelFeb 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently left review comments

@encukouencukouencukou approved these changes

Assignees

@markshannonmarkshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@markshannon@miss-islington@vstinner@terryjreedy@encukou@ericsnowcurrently@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp