NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-95371: Add support for other image formats(e.g. PNG) to the turtle…#95378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hugovk merged 12 commits intopython:mainfromrelent95:fix-issue-95371

Jan 2, 2025

Merged

gh-95371: Add support for other image formats(e.g. PNG) to the turtle…#95378

hugovk merged 12 commits intopython:mainfromrelent95:fix-issue-95371

Jan 2, 2025

Conversation

Copy link

Contributor

relent95 commentedJul 28, 2022•
edited by hugovk
Loading

Shape.__init__()
The existing buggy and dead code calling an instance methodTurtleScreen._image() as a class method was removed.(It has never been reached viaturtle.register_shape())
TurtleScreen.register_shape()
The existing redundant code checking the filename extension was removed because the backendtkinter.PhotoImage does that.
A new pattern for arguments, such asregister_shape("turtle", "turtle.gif") was added to be consistent with cases for polygon shapes.(It will be useful when the filename is quite long, as in case of using a full path.)
TurtleScreen.bgpic()
This already supports other image formats. So only the documentation was changed.

Issue:Add support for other image formats(e.g. PNG) to the turtle module #95371

pythongh-95371: Add support for other image formats(e.g. PNG) to the …

1e30349

…turtle module

bedevere-bot added the awaiting review label

Jul 28, 2022

Copy link

bedevere-bot commentedJul 28, 2022

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

📜🤖 Added by blurb_it.

79fa157

hugovk reviewed

Jul 29, 2022

View reviewed changes

Copy link

Member

hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some little spacing nits.

Also, any particular reason to list them in order PGM, PPM, GIF, and PNG?

I'd either put them in some sort of order of "popularity/ease of use" (e.g. "PNG, GIF, PGM, and PPM") or alphabetically ("GIF,PGM, PNG, and PPM").

Doc/library/turtle.rst OutdatedShow resolvedHide resolved

Lib/turtle.py OutdatedShow resolvedHide resolved

Misc/NEWS.d/next/Library/2022-07-28-12-32-59.gh-issue-95371.F24IFC.rst OutdatedShow resolvedHide resolved

Doc/library/turtle.rst OutdatedShow resolvedHide resolved

hugovk reviewed

Jul 29, 2022

View reviewed changes

Lib/turtle.py OutdatedShow resolvedHide resolved

relent95 added2 commits

August 1, 2022 09:56

Change the document to list popular image formats first

76c4c12

Merge branch 'fix-issue-95371' ofhttps://github.com/relent95/cpython…

ec58139

…into fix-issue-95371

Copy link

ContributorAuthor

relent95 commentedAug 1, 2022

Spaces were added as you suggested.
The list of supported formats were taken from the existing tkinter documentation(https://docs.python.org/3/library/tkinter.html). But I like your idea to list popular formats first and I did that.

Add a space before '(' in the documentation

782d596

Copy link

Member

arhadthedev commentedFeb 3, 2023

Mergingmain into this PR to check if#95371 (comment) is necessary:

[...] Because its base version is quite old, I can prepare a new PR if it's required.

Merge branch 'main' into fix-issue-95371

7bed9c0

bedevere-bot mentioned this pull request

Feb 3, 2023

Add support for other image formats(e.g. PNG) to the turtle module#95371

Closed

hugovk requested changes

Feb 6, 2023

View reviewed changes

Copy link

Member

hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please could you add someversionchanged orversionadded to document the changes/additions at the end of each function?

The next version will be 3.12.

Docs:https://devguide.python.org/documentation/markup/#paragraph-level-markup

bedevere-bot added awaiting changes and removed awaiting review labels

Feb 6, 2023

Copy link

bedevere-bot commentedFeb 6, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

This comment was marked as outdated.

relent95 added2 commits

December 28, 2024 17:40

Merge branch 'main' into fix-issue-95371

53c1ac4

Added versionchanged information to the two functions in the document

d7bfc33

Copy link

ContributorAuthor

relent95 commentedDec 28, 2024

@adorilson @hugovk I'll continue this work. Sorry for being too late. I updated the document by adding the versionchanged information. Can you review the change?

Copy link

Contributor

adorilson commentedDec 28, 2024

@adorilson @hugovk I'll continue this work. Sorry for being too late. I updated the document by adding the versionchanged information. Can you review the change?

Great news,@relent95 .

Now, the recommendation is that you useI have made the requested changes; please review again to the@bedevere-bot to do his work.

hugovk reviewed

Dec 29, 2024

View reviewed changes

Copy link

Member

hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, nearly there :)

Doc/library/turtle.rst OutdatedShow resolvedHide resolved

Misc/NEWS.d/next/Library/2022-07-28-12-32-59.gh-issue-95371.F24IFC.rst OutdatedShow resolvedHide resolved

Doc/library/turtle.rst OutdatedShow resolvedHide resolved

relent95 added2 commits

December 30, 2024 10:12

Merge branch 'main' into fix-issue-95371

5742a33

Refined the document as suggested by hugovk

a107c68

Copy link

ContributorAuthor

relent95 commentedDec 30, 2024

@bedevere-bot I have made the requested changes; please review again.

bedevere-appbot removed the awaiting changes label

Dec 30, 2024

bedevere-appbot added the awaiting change review label

Dec 30, 2024

Copy link

bedevere-appbot commentedDec 30, 2024

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

bedevere-appbot requested a review fromhugovk

December 30, 2024 01:53

hugovk reviewed

Dec 30, 2024

View reviewed changes

Doc/library/turtle.rst OutdatedShow resolvedHide resolved

relent95and others added2 commits

December 31, 2024 15:33

Merge branch 'main' into fix-issue-95371

6d45a72

Update Doc/library/turtle.rst

0644d71

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

Copy link

ContributorAuthor

relent95 commentedDec 31, 2024

@bedevere-bot I have made the requested changes; please review again.

Copy link

bedevere-appbot commentedDec 31, 2024

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

bedevere-appbot requested a review fromhugovk

December 31, 2024 06:42

hugovk approved these changes

Jan 2, 2025

View reviewed changes

Copy link

Member

hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

bedevere-appbot added awaiting merge and removed awaiting change review labels

Jan 2, 2025

hugovk merged commite1baa77 intopython:main

Jan 2, 2025

41 of 42 checks passed

bedevere-appbot removed the awaiting merge label

Jan 2, 2025

relent95 deleted the fix-issue-95371 branch

January 3, 2025 00:36

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request

Jan 8, 2025

pythongh-95371: Add support for other image formats(e.g. PNG) to the …

b3a6c43

…turtle… (python#95378)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>

Labels

None yet

Movatterモバイル変換

Uh oh!

gh-95371: Add support for other image formats(e.g. PNG) to the turtle…#95378

gh-95371: Add support for other image formats(e.g. PNG) to the turtle…#95378

Uh oh!

Conversation

relent95 commentedJul 28, 2022• edited by hugovkLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commentedJul 28, 2022

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

relent95 commentedAug 1, 2022

Uh oh!

arhadthedev commentedFeb 3, 2023

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commentedFeb 6, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

relent95 commentedDec 28, 2024

Uh oh!

adorilson commentedDec 28, 2024

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

relent95 commentedDec 30, 2024

Uh oh!

bedevere-appbot commentedDec 30, 2024

Uh oh!

Uh oh!

relent95 commentedDec 31, 2024

Uh oh!

bedevere-appbot commentedDec 31, 2024

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

relent95 commentedJul 28, 2022•
edited by hugovk
Loading