Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
[3.10] gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcher (GH-95009)#95093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…s_fails_with_inactive_watcher (pythonGH-95009)The test was never run, because it was missing the TestCase class.The test failed because the wrong attribute was patched.(cherry picked from commit834bd5d)Co-authored-by: Thomas Grainger <tagrain@gmail.com>
miss-islington commentedJul 21, 2022
Status check is done, and it's a success ✅ . |
1 similar comment
miss-islington commentedJul 21, 2022
Status check is done, and it's a success ✅ . |
miss-islington commentedJul 21, 2022
@graingert and@serhiy-storchaka: Status check is done, and it's a success ❌ . |
graingert commentedJul 21, 2022
@kumaraditya303 I need to edit this to get the tests to pass on the backport, but I can't push to this branch should I open a new PR? |
kumaraditya303 commentedJul 21, 2022
Yes, you have to manually create a PR. |
graingert commentedJul 21, 2022
Thanks I'll do that now |
Uh oh!
There was an error while loading.Please reload this page.
The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit834bd5d)
Co-authored-by: Thomas Graingertagrain@gmail.com
GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcheris not run #95010