Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-95010: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…#95009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@graingert
Copy link
Contributor

@graingertgraingert commentedJul 19, 2022•
edited by bedevere-bot
Loading

fix asyncioGenericWatcherTests.test_create_subprocess_fails_with_inactive_watcher

the test was never run, because it was missing the TestCase class
the test failed because the wrong attribute was patched

@bedevere-botbedevere-bot added testsTests in the Lib/test dir awaiting review labelsJul 19, 2022
@graingertgraingert changed the titlefix GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…Jul 19, 2022
@graingertgraingertforce-pushed thefix-generic-watcher-tests branch from823b0c4 to9877b92CompareJuly 19, 2022 15:32
@graingertgraingert changed the titlefix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…gh-95009: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…Jul 19, 2022
@graingert
Copy link
ContributorAuthor

this is just a test change and doesn't need news

@graingertgraingert changed the titlegh-95009: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…gh-95010: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…Jul 19, 2022
…s_fails_with_inactive_watcherthe test was never run, because it was missing the TestCase classthe test failed because the wrong attribute was patched
@graingertgraingertforce-pushed thefix-generic-watcher-tests branch from4f47e21 to20b9bd0CompareJuly 19, 2022 15:50
@graingert
Copy link
ContributorAuthor

It's best to review this in side-by-side mode, because GenericWatcherTests needed to be indented:https://github.com/python/cpython/pull/95009/files?diff=split

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

graingert reacted with heart emoji
@graingert
Copy link
ContributorAuthor

This should probably be backported to 3.10 as it's needed to verify a bugfix

@kumaraditya303kumaraditya303 added needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsJul 21, 2022
@serhiy-storchakaserhiy-storchaka merged commit834bd5d intopython:mainJul 21, 2022
@miss-islington
Copy link
Contributor

Thanks@graingert for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-95092 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed needs backport to 3.11only security fixes needs backport to 3.10only security fixes labelsJul 21, 2022
@bedevere-bot
Copy link

GH-95093 is a backport of this pull request to the3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 21, 2022
…s_fails_with_inactive_watcher (pythonGH-95009)The test was never run, because it was missing the TestCase class.The test failed because the wrong attribute was patched.(cherry picked from commit834bd5d)Co-authored-by: Thomas Grainger <tagrain@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 21, 2022
…s_fails_with_inactive_watcher (pythonGH-95009)The test was never run, because it was missing the TestCase class.The test failed because the wrong attribute was patched.(cherry picked from commit834bd5d)Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@graingertgraingert deleted the fix-generic-watcher-tests branchJuly 21, 2022 11:57
miss-islington added a commit that referenced this pull requestJul 21, 2022
…s_with_inactive_watcher (GH-95009)The test was never run, because it was missing the TestCase class.The test failed because the wrong attribute was patched.(cherry picked from commit834bd5d)Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@graingert@miss-islington@bedevere-bot@serhiy-storchaka@kumaraditya303@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp