Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-82504: deprecate the MultiLoopChildWatcher#94648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@graingert
Copy link
Contributor

@graingertgraingert commentedJul 7, 2022•
edited by bedevere-bot
Loading

@graingertgraingert changed the titlebpo-82504: deprecate the MultiLoopChildWatchergh-82504: deprecate the MultiLoopChildWatcherJul 7, 2022
@graingertgraingert marked this pull request as ready for reviewJuly 7, 2022 09:18
Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It would be better to add What's New entry about this deprecation.

…tYAz.rstCo-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@graingertgraingertforce-pushed thedeprecate-multi-loop-watcher branch from84a0ca0 to2e6e996CompareJuly 18, 2022 16:20
Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@graingert
Copy link
ContributorAuthor

thanks for the review@kumaraditya303 !

kumaraditya303 reacted with thumbs up emoji

@kumaraditya303
Copy link
Contributor

@gvanrossum Would you like to review this? This deprecatesMultiLoopChildWatcher which has race conditions so it is not even tested on CI currently, skipped on CI as of#26542.

@gvanrossum
Copy link
Member

I'm sorry, I don't feel comfortable reviewing this. Any core dev CC'ed on the issue would be more qualified than me.

@gvanrossumgvanrossum removed their request for reviewJuly 18, 2022 23:12
@graingert
Copy link
ContributorAuthor

@kumaraditya303 can you request@njsmith on this?

@kumaraditya303
Copy link
Contributor

kumaraditya303 commentedOct 9, 2022•
edited
Loading

Superseded by#98089

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@njsmithnjsmithAwaiting requested review from njsmith

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@graingert@kumaraditya303@gvanrossum@AlexWaygood@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp