Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-51574: Make tempfile.mkdtemp() always return absolute paths#94612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 12 commits intopython:mainfromkj7rrv:mkdtemp-absolute
Apr 25, 2023

Conversation

kj7rrv
Copy link
Contributor

@kj7rrvkj7rrv commentedJul 6, 2022•
edited by AlexWaygood
Loading

@kj7rrv
Copy link
ContributorAuthor

@merwoka9098be adds a test

@kj7rrv
Copy link
ContributorAuthor

I tested the test both with and without the fix, and it passes with the fix and fails without it.

kj7rrvand others added2 commitsJuly 7, 2022 07:43
Co-authored-by: Éric <merwok@netwok.org>
Copy link
Contributor

@mblahaymblahay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The changes here are sound.

…eUeD.rstSuggested by@merwokCo-authored-by: Éric <merwok@netwok.org>
@mblahay
Copy link
Contributor

@ambv I have taken a look at this and all seems to be in good order. Can this be moved forward?

@arhadthedev
Copy link
Member

Mergingmain again to unstuckDO-NOT-MERGE / unresolved review.

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@kj7rrv! This looks good to me. I'll merge once CI passes.

This will just go into 3.12, as there is a small chance of this breaking someone's code if this were backported.

mblahay and kj7rrv reacted with thumbs up emoji
@AlexWaygoodAlexWaygoodenabled auto-merge (squash)April 25, 2023 15:41
@AlexWaygoodAlexWaygood merged commit32bea69 intopython:mainApr 25, 2023
@mblahay
Copy link
Contributor

Thank you@AlexWaygood , and congratulations@kj7rrv !

AlexWaygood and kj7rrv reacted with hooray emoji

itamaro pushed a commit to itamaro/cpython that referenced this pull requestApr 26, 2023
…ython#94612)Co-authored-by: Éric <merwok@netwok.org>Co-authored-by: AlexWaygood <alex.waygood@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@merwokmerwokmerwok left review comments

@mblahaymblahaymblahay approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@kj7rrv@mblahay@arhadthedev@merwok@AlexWaygood@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp