Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-94603: micro optimize list.pop#94604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
corona10 merged 17 commits intopython:mainfromeendebakpt:performance/list_pop
Dec 27, 2022

Conversation

eendebakpt
Copy link
Contributor

@eendebakpteendebakpt commentedJul 6, 2022•
edited by bedevere-bot
Loading

This PR optmizeslist.pop

Benchmark results

x=[1,2]; x.pop(0): Mean +- std dev: [m2] 81.8 ns +- 2.5 ns -> [pr_special] 68.9 ns +- 2.0 ns: 1.19x fasterx=[1,2]; x.pop(1): Mean +- std dev: [m2] 65.4 ns +- 2.1 ns -> [pr_special] 64.4 ns +- 0.6 ns: 1.02x fasterx=[]; x.insert(0,1); x.pop(0): Mean +- std dev: [m2] 111 ns +- 3 ns -> [pr_special] 80.2 ns +- 1.1 ns: 1.38x fasterlist(0): insert(0, None) + pop(0): Mean +- std dev: [m2] 78.4 ns +- 0.8 ns -> [pr_special] 62.1 ns +- 1.3 ns: 1.26x fasterlist(1): insert(0, None) + pop(1): Mean +- std dev: [m2] 59.7 ns +- 0.4 ns -> [pr_special] 57.7 ns +- 0.9 ns: 1.04x fasterlist(2): insert(0, None) + pop(1): Mean +- std dev: [m2] 66.9 ns +- 0.6 ns -> [pr_special] 55.5 ns +- 1.8 ns: 1.20x fasterlist(10): insert(0, None) + pop(1): Mean +- std dev: [m2] 71.9 ns +- 0.6 ns -> [pr_special] 62.4 ns +- 2.8 ns: 1.15x fasterlist(100): insert(0, None) + pop(1): Mean +- std dev: [m2] 108 ns +- 4 ns -> [pr_special] 93.5 ns +- 3.3 ns: 1.16x fasterlist(10000): insert(0, None) + pop(1): Mean +- std dev: [m2] 5.41 us +- 0.02 us -> [pr_special] 5.37 us +- 0.02 us: 1.01x fasterBenchmark hidden because not significant (2): x=[1]; x.pop(0), sortedcontainerGeometric mean: 1.12x faster
Benchmark code
import pyperfimport sortedcontainersrunner = pyperf.Runner()runner.timeit(name=f"x=[1]; x.pop(0)",stmt='x=[1]; x.pop(0)')runner.timeit(name=f"x=[1,2]; x.pop(0)", stmt='x=[1,2]; x.pop(0)')runner.timeit(name=f"x=[1,2]; x.pop(1)",stmt='x=[1,2]; x.pop(1)')runner.timeit(name=f"x=[]; x.insert(0,1); x.pop(0)",stmt='x=[]; x.insert(0,1); x.pop(0)')runner.timeit(name=f"list(0): insert(0, None) + pop(0)", stmt="lst.insert(0, None); lst.pop(0)", setup='lst=[]')for n in [ 1, 2, 10, 100, 10_000]:    runner.timeit(name=f"list({n}): insert(0, None) + pop(1)",      stmt="lst.insert(0, None); lst.pop(1)", setup=f'import random; lst=[random.random() for ii in range({n})]')setup ="import random; import sortedcontainers; sc=sortedcontainers.SortedList(); x=[random.random() for n in range(1_00_000)]"runner.timeit(name=f"sortedcontainer", stmt="[sc.add(v) for v in x]", setup=setup)

@AlexWaygoodAlexWaygood added type-featureA feature request or enhancement performancePerformance or resource usage labelsJul 6, 2022
@corona10
Copy link
Member

@serhiy-storchaka is the expert who can decide these kinds of micro-optimization is worth applying :)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@serhiy-storchaka
Copy link
Member

I am a bit surprised to see a significant difference in that microbenchmarks. The method call adds an overhead, and since this method is not idempotent, you need to add even more expensive code to create a list or adding an item in the existing list list at every iteration, so I expected the difference be rather unnoticeable. But I repeated microbenchmarking myself and confirm the results. It looks interesting.

Now, we need to analyze, why we get such significant speedup, can the optimization be generalized to other methods, can we get the same results with simpler changes?

corona10 and eendebakpt reacted with thumbs up emoji

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@eendebakpt
Copy link
ContributorAuthor

@serhiy-storchaka Here are some more details

  • Thetest/test_list.py is not part of the PGO cycle. Thelist.pop is called multiple times though, so it is part of the profiling so I did not change that
  • The specialization for popping the last element of a list is required to achieve the same performance as currentmain. Benchmarks onrunner.timeit(name=f"pop last item",stmt='x=[1,2,3]; x.pop(-1)'):

Main

pop last item: Mean +- std dev: 68.2 ns +- 0.8 ns

PR

pop last item: Mean +- std dev: 65.0 ns +- 1.1 ns

PR: No specialization for last element

pop last item: Mean +- std dev: 73.6 ns +- 0.5 ns
  • The specialization for empty lists is required as well. Benchmarkrunner.timeit(name=f"pop to empty",stmt='x=[1,]; x.pop(0)'):

Main

pop to empty: Mean +- std dev: 64.0 ns +- 0.4 ns

PR

pop to empty: Mean +- std dev: 61.5 ns +- 0.9 ns

PR: No specialization for last element

pop to empty: Mean +- std dev: 64.5 ns +- 0.4 ns

(differences are small though)

  • The reason for the speedup might be that we avoid an extra call tomemcopy inlist_ass_slice (e.g. we replacememcpy(recycle, &item[ilow], s); with a direct assignment)

@eendebakpt
Copy link
ContributorAuthor

Added similar optimizations tolist_ass_slice does not seem to have the same performance benefits. Not sure why that is

main...eendebakpt:list_assignment_optimization

results in:

x=[1,2]; x.pop(0): Mean +- std dev: [m5] 80.8 ns +- 1.1 ns -> [pr_slice3] 79.3 ns +- 3.2 ns: 1.02x fasterx=[1,2]; x.pop(1): Mean +- std dev: [m5] 65.0 ns +- 0.4 ns -> [pr_slice3] 66.7 ns +- 2.1 ns: 1.03x slowerlist(0): insert(0, None) + pop(0): Mean +- std dev: [m5] 79.1 ns +- 0.6 ns -> [pr_slice3] 83.8 ns +- 0.5 ns: 1.06x slowerlist(50): x.append(1); x.pop(-2): Mean +- std dev: [m5] 48.1 ns +- 1.4 ns -> [pr_slice3] 45.6 ns +- 0.3 ns: 1.06x fasterlist(1): insert(0, None) + pop(1): Mean +- std dev: [m5] 57.6 ns +- 1.0 ns -> [pr_slice3] 61.7 ns +- 0.3 ns: 1.07x slowerlist(2): insert(0, None) + pop(1): Mean +- std dev: [m5] 64.8 ns +- 0.5 ns -> [pr_slice3] 68.0 ns +- 2.2 ns: 1.05x slowerlist(10): insert(0, None) + pop(1): Mean +- std dev: [m5] 69.1 ns +- 1.0 ns -> [pr_slice3] 73.3 ns +- 1.8 ns: 1.06x slowerlist(100): insert(0, None) + pop(1): Mean +- std dev: [m5] 119 ns +- 2 ns -> [pr_slice3] 108 ns +- 4 ns: 1.11x fasterlist(10000): insert(0, None) + pop(1): Mean +- std dev: [m5] 5.82 us +- 0.03 us -> [pr_slice3] 5.40 us +- 0.16 us: 1.08x fastersortedcontainer: Mean +- std dev: [m5] 105 ms +- 1 ms -> [pr_slice3] 110 ms +- 4 ms: 1.05x slowerBenchmark hidden because not significant (2): x=[1]; x.pop(0), x=[]; x.insert(0,1); x.pop(0)Geometric mean: 1.00x slower

@eendebakpt
Copy link
ContributorAuthor

eendebakpt commentedAug 2, 2022•
edited
Loading

Added similar optimizations tolist_ass_slice does not seem to have the same performance benefits. Not sure why that is

A small variantmain...eendebakpt:list_assignment_optimization2 also gives performance similar tomain. Avoiding a single memcpy does not fully explain the performance gain.

Thelist_ass_slice does more work than is required for the case of a simple pop. When calling fromlist_pop_impl there are 7 redundant if statements. E.g. if-statements that are required for the implementation oflist_ass_slice, but that would not be required if the method is only called fromlist_pop_impl.
The additional 7 if statements (and avoided memcpy) can perhaps explain the performance difference we see. So the performance gain is not due to a single improvement, but a combination of several small gains added together.

@serhiy-storchaka

@eendebakpteendebakpt requested review fromcorona10 and removed request forserhiy-storchakaDecember 22, 2022 20:12
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10corona10 self-assigned thisDec 24, 2022
@eendebakpt
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

@corona10corona10 added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelDec 27, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@corona10 for commit7c1a835 🤖

If you want to schedule another build, you need to add the:hammer: test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelDec 27, 2022
Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm with nit comment

@corona10corona10 added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelDec 27, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@corona10 for commit23eb3aa 🤖

If you want to schedule another build, you need to add the:hammer: test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelDec 27, 2022
@corona10corona10 merged commitb3da698 intopython:mainDec 27, 2022
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM Raspbian 3.x has failed when building commitb3da698.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/3192) and take a look at the build logs.
  4. Check if the failure is related to this commit (b3da698) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/3192

Failed tests:

  • test_eintr

Failed subtests:

  • test_all - test.test_eintr.EINTRTests.test_all
  • test_flock -main.FNTLEINTRTest.test_flock

Summary of the results of the build (if available):

== Tests result: FAILURE then ENV CHANGED ==

411 tests OK.

10 slowest tests:

  • test_largefile: 6 min 34 sec
  • test_venv: 6 min 6 sec
  • test_eintr: 5 min 14 sec
  • test_multiprocessing_spawn: 3 min 54 sec
  • test_asyncio: 3 min 10 sec
  • test_concurrent_futures: 2 min 56 sec
  • test_multiprocessing_forkserver: 2 min 36 sec
  • test_compileall: 2 min 10 sec
  • test_tokenize: 2 min 4 sec
  • test_gdb: 1 min 59 sec

1 test altered the execution environment:
test_multiprocessing_forkserver

21 tests skipped:
test_check_c_globals test_devpoll test_idle test_ioctl test_kqueue
test_launcher test_msilib test_peg_generator test_perf_profiler
test_startfile test_tcl test_tix test_tkinter test_ttk
test_ttk_textonly test_turtle test_winconsoleio test_winreg
test_winsound test_wmi test_zipfile64

1 re-run test:
test_eintr

Total duration: 31 min 18 sec

Click to see traceback logs
Traceback (most recent call last):  File"/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_eintr.py", line16, intest_all    script_helper.run_test_script(script)  File"/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/support/script_helper.py", line300, inrun_test_scriptraiseAssertionError(f"{name} failed")AssertionError:script _test_eintr.py failedTraceback (most recent call last):  File"/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/_test_eintr.py", line526, intest_flockself._lock(fcntl.flock,"flock")  File"/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/_test_eintr.py", line508, in_lockraiseException("failed to sync child in%.1f sec"% dt)Exception:failed to sync child in 300.3 sec

iritkatriel added a commit to iritkatriel/cpython that referenced this pull requestDec 28, 2022
* CorrectCVE-2020-10735 documentation (python#100306)*pythongh-94912: Added marker for non-standard coroutine function detection (python#99247)This introduces a new decorator `@inspect.markcoroutinefunction`,which, applied to a sync function, makes it appear async to`inspect.iscoroutinefunction()`.* Docs: Don't upload CI artifacts (python#100330)*pythongh-89727: Fix os.walk RecursionError on deep trees (python#99803)Use a stack to implement os.walk iteratively instead of recursively toavoid hitting recursion limits on deeply nested trees.*pythongh-69929: re docs: Add more specific definition of \w (python#92015)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>*pythongh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (python#93927)Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Christian Heimes <christian@python.org>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Fixespython#89051*pythongh-88211: Change lower-case and upper-case to match recommendations in imaplib docs (python#99625)*pythongh-100348: Fix ref cycle in `asyncio._SelectorSocketTransport` with `_read_ready_cb` (python#100349)*pythongh-99925: Fix inconsistency in `json.dumps()` error messages (pythonGH-99926)* Clarify that every thread has its own default context in contextvars (python#99246)*pythongh-99576: Fix cookiejar file that was not truncated for some classes (pythonGH-99616)Co-authored-by: Łukasz Langa <lukasz@langa.pl>*pythongh-100188: Reduce misses in BINARY_SUBSCR_(LIST/TUPLE)_INT (python#100189)Don't specialize if the index is negative.*pythongh-99991: improve docs on str.encode and bytes.decode (python#100198)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>*pythongh-91081: Add note on WeakKeyDictionary behavior when deleting a replaced entry (python#91499)Co-authored-by: Pieter Eendebak <P.T.eendebak@tudelft.nl>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>*pythongh-85267: Improvements to inspect.signature __text_signature__ handling (python#98796)This makes a couple related changes to inspect.signature's behaviourwhen parsing a signature from `__text_signature__`.First, `inspect.signature` is documented as only raising ValueError orTypeError. However, in some cases, we could raise RuntimeError.  This PRchanges that, thereby fixingpython#83685.(Note that the new ValueErrors in RewriteSymbolics are caught and thenreraised with a message)Second, `inspect.signature` could randomly drop parameters that itdidn't understand (corresponding to `return None` in the `p` function).This is the core issue inpython#85267. I think this is very surprisingbehaviour and it seems better to fail outright.Third, adding this new failure broke a couple tests. To fix them (and toe.g. allow `inspect.signature(select.epoll.register)` as inpython#85267), Iadd constant folding of a couple binary operations to RewriteSymbolics.(There's some discussion of making signature expression evaluationarbitrary powerful inpython#68155. I think that's out of scope. Theadditional constant folding here is pretty straightforward, useful, andnot much of a slippery slope)Fourth, whilepython#85267 is incorrect about the cause of the issue, it turnsout if you had consecutive newlines in __text_signature__, you'd get`tokenize.TokenError`.Finally, the `if name is invalid:` code path was dead, since`parse_name` never returned `invalid`.*pythonGH-100363: Speed up `asyncio.get_running_loop` (python#100364)*pythonGH-100133: fix `asyncio` subprocess losing `stderr` and `stdout` output (python#100154)*pythongh-100374: Fixed a bug in socket.getfqdn() (pythongh-100375)*pythongh-100129: Add tests for pickling all builtin types and functions (pythonGH-100142)* Remove unused variable from `dis._find_imports` (python#100396)*pythongh-78878: Fix crash when creating an instance of `_ctypes.CField` (python#14837)*pythonGH-69564: Clarify use of octal format of mode argument in help(os.chmod) (python#20621)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>*pythonGH-99554: Pack location tables more effectively (pythonGH-99556)* Correct typo in typing.py (python#100423)In the docstring of `ParamSpec`, the name of `P = ParamSpec('P')` wasmistakenly written as `'T'`.*pythongh-99761: Add `_PyLong_IsPositiveSingleDigit` function to check for single digit integers  (python#100064)*pythonGH-99770: Make the correct call specialization fail kind show up in the stats (pythonGH-99771)*pythongh-78997: fix bad rebase of moved test file (python#100424)*pythongh-100344: Add C implementation for `asyncio.current_task` (python#100345)Co-authored-by: pranavtbhat*pythonGH-99554: Trim trailing whitespace (pythonGH-100435)Automerge-Triggered-By: GH:brandtbucher*pythongh-85432: Harmonise parameter names between C and pure-Python implementations of `datetime.time.strftime`, `datetime.datetime.fromtimestamp` (python#99993)*pythongh-57762: fix misleading tkinter.Tk docstring (python#98837)Mentioned as a desired change by terryjreedy on the corresponding issue,since Tk is not a subclass of Toplevel.*pythongh-48496: Added example and link to faq for UnboundLocalError in reference (python#93068)* Fix typo in 3.12 What's New (python#100449)*pythongh-76963: PEP3118 itemsize of an empty ctypes array should not be 0 (pythonGH-5576)The itemsize returned in a memoryview of a ctypes array is now computed from the item type, instead of dividing the total size by the length and assuming that the length is not zero.*pythonGH-100459: fix copy-paste errors in specialization stats (pythonGH-100460)*pythongh-99110: Initialize `frame->previous` in init_frame to fix segmentation fault when accessing `frame.f_back` (python#100182)*pythongh-98712: Clarify "readonly bytes-like object" semantics in C arg-parsing docs (python#98710)*pythongh-92216: improve performance of `hasattr` for type objects (pythonGH-99979)*pythongh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries (pythonGH-100289)* Revert "pythongh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries (pythonGH-100289)" (python#100468)This reverts commitc3c7848.*pythongh-94155: Reduce hash collisions for code objects (python#100183)* Uses a better hashing algorithm to get better dispersion and remove commutativity.* Incorporates `co_firstlineno`, `Py_SIZE(co)`, and bytecode instructions.* This is now the entire set of criteria used in `code_richcompare`, except for `_PyCode_ConstantKey` (which would incorporate the types of `co_consts` rather than just their values).*pythongh-83076: 3.8x speed improvement in (Async)Mock instantiation (python#100252)*pythongh-99482: remove `jython` compatibility parts from stdlib and tests (python#99484)* bpo-40447: accept all path-like objects in compileall.compile_file (python#19883)Signed-off-by: Filipe Laíns <lains@archlinux.org>Signed-off-by: Filipe Laíns <lains@riseup.net>Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>*pythonGH-100425: Improve accuracy of builtin sum() for float inputs (pythonGH-100426)*pythongh-68320,pythongh-88302 - Allow for private `pathlib.Path` subclassing (pythonGH-31691)Users may wish to define subclasses of `pathlib.Path` to add or modifyexisting methods. Before this change, attempting to instantiate a subclassraised an exception like:    AttributeError: type object 'PPath' has no attribute '_flavour'Previously the `_flavour` attribute was assigned as follows:    PurePath._flavour        = xxx not set!! xxx    PurePosixPath._flavour   = _PosixFlavour()    PureWindowsPath._flavour = _WindowsFlavour()This change replaces it with a `_pathmod` attribute, set as follows:    PurePath._pathmod        = os.path    PurePosixPath._pathmod   = posixpath    PureWindowsPath._pathmod = ntpathFunctionality from `_PosixFlavour` and `_WindowsFlavour` is moved into`PurePath` as underscored-prefixed classmethods. Flavours are removed.Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: Brett Cannon <brett@python.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Eryk Sun <eryksun@gmail.com>*pythongh-99947: Ensure unreported errors are chained for SystemError during import (pythonGH-99946)* Add "strict" to dotproduct(). Add docstring. Factor-out common code. (pythonGH-100480)*pythongh-94808: improve test coverage of number formatting (python#99472)*pythongh-100454: Start running SSL tests with OpenSSL 3.1.0-beta1 (python#100456)*pythongh-100268: Add is_integer method to int (python#100439)This improves the lives of type annotation users of `float` - which type checkers implicitly treat as `int|float` because that is what most code actually wants. Before this change a `.is_integer()` method could not be assumed to exist on things annotated as `: float` due to the method not existing on both types.*pythongh-77771: Add enterabs example in sched (python#92716)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>*pythonGH-91166: Implement zero copy writes for `SelectorSocketTransport` in asyncio (python#31871)Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>*pythonGH-91166: Implement zero copy writes for `SelectorSocketTransport` in asyncio (python#31871)Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>* Misc Itertools recipe tweaks (pythonGH-100493)*pythongh-100357: Convert several functions in `bltinsmodule` to AC (python#100358)* Remove wrong comment about `repr` in `test_unicode` (python#100495)*pythongh-99908: Tutorial: Modernize the 'data-record class' example (python#100499)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>*pythongh-100474: Fix handling of dirs named index.html in http.server (pythonGH-100475)If you had a directory called index.html or index.htm within a directory, it would cause http.server to return a 404 Not Found error instead of the directory listing. This came about due to not checking that the index was a regular file.I have also added a test case for this situation.Automerge-Triggered-By: GH:merwok*pythongh-100287: Fix unittest.mock.seal with AsyncMock (python#100496)*pythongh-99535: Add test for inheritance of annotations and update documentation (python#99990)*pythongh-100428: Make float documentation more accurate (python#100437)Previously, the grammar did not accept `float("10")`.Also implement mdickinson's suggestion of removing the indirection.* [Minor PR] Quotes in documentation changed into code blocks (python#99536)Minor formatting fix in documentationCo-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>*pythongh-100472: Fix docs claim that compileall parameters could be bytes (python#100473)*pythongh-100519: simplification to `eff_request_host` in cookiejar.py (python#99588)`IPV4_RE` includes a `.`, and the `.find(".") == -1` included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern `in` syntax to make it clear what the check is doing here. The simplified implementation more clearly matches the wording in RFC 2965.Co-authored-by: hauntsaninja <hauntsaninja@gmail.com>*pythongh-99308: Clarify re docs for byte pattern group names (python#99311)*pythongh-92446: Improve argparse choices docs; revert bad change to lzma docs (python#94627)Based on the definition of the collections.abc classes, it is more accurate to use "sequence" instead of "container" when describing argparse choices.A previous attempt at fixing this inpython#92450 was mistaken; this PR reverts that change.Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>* Fix name of removed `inspect.Signature.from_builtin` method in 3.11.0a2 changelog (python#100525)*pythongh-100520: Fix `rst` markup in `configparser`  docstrings (python#100524)*pythongh-99509: Add `__class_getitem__` to `multiprocessing.queues.Queue` (python#99511)*pythongh-94603: micro optimize list.pop (pythongh-94604)* Remove `NoneType` redefinition from `clinic.py` (python#100551)*pythongh-100553: Improve accuracy of sqlite3.Row iter test (python#100555)*pythonGH-98831: Modernize a ton of simpler instructions (python#100545)* load_const and load_fast aren't families for now* Don't decref unmoved names* Modernize GET_ANEXT* Modernize GET_AWAITABLE* Modernize ASYNC_GEN_WRAP* Modernize YIELD_VALUE* Modernize POP_EXCEPT (in more than one way)* Modernize PREP_RERAISE_STAR* Modernize LOAD_ASSERTION_ERROR* Modernize LOAD_BUILD_CLASS* Modernize STORE_NAME* Modernize LOAD_NAME* Modernize LOAD_CLASSDEREF* Modernize LOAD_DEREF* Modernize STORE_DEREF* Modernize COPY_FREE_VARS (mark it as done)* Modernize LIST_TO_TUPLE* Modernize LIST_EXTEND* Modernize SET_UPDATE* Modernize SETUP_ANNOTATIONS* Modernize DICT_UPDATE* Modernize DICT_MERGE* Modernize MAP_ADD* Modernize IS_OP* Modernize CONTAINS_OP* Modernize CHECK_EXC_MATCH* Modernize IMPORT_NAME* Modernize IMPORT_STAR* Modernize IMPORT_FROM* Modernize JUMP_FORWARD (mark it as done)* Modernize JUMP_BACKWARD (mark it as done)Signed-off-by: Filipe Laíns <lains@archlinux.org>Signed-off-by: Filipe Laíns <lains@riseup.net>Co-authored-by: Jeremy Paige <ucodery@gmail.com>Co-authored-by: Carlton Gibson <carlton@noumenal.es>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Jon Burdo <jon@jonburdo.com>Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Thomas Grainger <tagrain@gmail.com>Co-authored-by: Brad Wolfe <brad.wolfe@gmail.com>Co-authored-by: Richard Kojedzinszky <rkojedzinszky@users.noreply.github.com>Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Łukasz Langa <lukasz@langa.pl>Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>Co-authored-by: Bisola Olasehinde <horlasehinde@gmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Pieter Eendebak <P.T.eendebak@tudelft.nl>Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>Co-authored-by: Dominic Socular <BBH@awsl.rip>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Hai Shi <shihai1992@gmail.com>Co-authored-by: amaajemyfren <32741226+amaajemyfren@users.noreply.github.com>Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>Co-authored-by: david-why <david_why@outlook.com>Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>Co-authored-by: penguin_wwy <940375606@qq.com>Co-authored-by: Eli Schwartz <eschwartz93@gmail.com>Co-authored-by: Itamar Ostricher <itamarost@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: Eric Wieser <wieser.eric@gmail.com>Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>Co-authored-by: Bill Fisher <william.w.fisher@gmail.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Ken Jin <kenjin@python.org>Co-authored-by: Carl Meyer <carl@oddbird.net>Co-authored-by: Filipe Laíns <lains@riseup.net>Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>Co-authored-by: Barney Gale <barney.gale@gmail.com>Co-authored-by: Brett Cannon <brett@python.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Eryk Sun <eryksun@gmail.com>Co-authored-by: Sebastian Berg <sebastianb@nvidia.com>Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com>Co-authored-by: James Frost <git@frost.cx>Co-authored-by: MonadChains <monadchains@gmail.com>Co-authored-by: Bart Broere <mail@bartbroere.eu>Co-authored-by: Glyph <code@glyph.im>Co-authored-by: hauntsaninja <hauntsaninja@gmail.com>Co-authored-by: Ilya Kulakov <kulakov.ilya@gmail.com>Co-authored-by: Guy Yagev <yourlefthandman8@gmail.com>Co-authored-by: Jakub Kuczys <me@jacken.men>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@corona10corona10corona10 requested changes

Assignees

@corona10corona10

Labels
performancePerformance or resource usagetype-featureA feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@eendebakpt@corona10@serhiy-storchaka@bedevere-bot@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp