Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-93896: always set event loop in asyncio.run and IsolatedAsyncioTestCase#94593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 5 commits intopython:mainfromkumaraditya303:asyncio-ev
Jul 6, 2022

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commentedJul 6, 2022
edited by bedevere-bot
Loading

@graingert
Copy link
Contributor

Can you copy over the test cases from my PR?

@kumaraditya303
Copy link
ContributorAuthor

Can you copy over the test cases from my PR?

I added a test.

Copy link
Contributor

@asvetlovasvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for the fix!

kumaraditya303 and ericsnowcurrently reacted with heart emoji
@kumaraditya303
Copy link
ContributorAuthor

LGTM, thanks for the fix!

Thanks for the reviews!

@graingert
Copy link
Contributor

graingert commentedJul 6, 2022
edited
Loading

I think the docs should describe this change:

class Runner:    """A context manager that controls event loop life cycle.    The context manager always creates a new event loop,    allows to run async functions inside it, sets the policy loop,    and properly finalizes the loop at the context manager exit.    If debug is True, the event loop will be run in debug mode.    If loop_factory is passed, it is used for new event loop creation, however the    policy loop will not be set

@kumaraditya303
Copy link
ContributorAuthor

kumaraditya303 commentedJul 6, 2022
edited
Loading

I think the docs should describe this change:

class Runner:    """A context manager that controls event loop life cycle.    The context manager always creates a new event loop,    allows to run async functions inside it, sets the policy loop,    and properly finalizes the loop at the context manager exit.    If debug is True, the event loop will be run in debug mode.    If loop_factory is passed, it is used for new event loop creation, however the    policy loop will not be set

This would complicate things for an average user about how policy registry works. The existing docs is clearIf loop_factory is passed, it is used for new event loop creation. We can iterate over docs afterwards but let's fix the release blockers first.

asvetlov and graingert reacted with thumbs up emoji

@pablogsalpablogsal merged commit14fea6b intopython:mainJul 6, 2022
@miss-islington
Copy link
Contributor

Thanks@kumaraditya303 for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-94608 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 6, 2022
…ncioTestCase (pythonGH-94593)(cherry picked from commit14fea6b)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303kumaraditya303 deleted the asyncio-ev branchJuly 6, 2022 15:20
miss-islington added a commit that referenced this pull requestJul 6, 2022
…stCase (GH-94593)(cherry picked from commit14fea6b)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@graingertgraingertgraingert requested changes

@asvetlovasvetlovasvetlov approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@pablogsalpablogsalAwaiting requested review from pablogsal

Assignees

@kumaraditya303kumaraditya303

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kumaraditya303@graingert@miss-islington@bedevere-bot@asvetlov@pablogsal

[8]ページ先頭

©2009-2025 Movatter.jp