Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-94590: add signatures to operator itemgetter, attrgetter, methodcaller#94591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…thodcallerThese were intentionally skipped when operator was updated to use the argument clinic:python#64385 (comment)However, by not using the argument clinic, they missed out on getting signatures.This is a narrow PR to update the docstrings so that `__text_signature__` can beextracted from them. Updating to use the argument clinic is beyond scope.`methodcaller` uses `*args, **kwargs` to match variadic names used elsewhere,including in `operator.call`.
kumaraditya303 approved these changesSep 4, 2022
JelleZijlstra approved these changesOct 3, 2022
carljm added a commit to carljm/cpython that referenced this pull requestOct 6, 2022
* main:fixespythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)pythongh-97850: Remove the open issues section from the import reference (python#97935) Docs: pin sphinx-lint (pythonGH-97992)pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591) Add Pynche's move to the What's new in 3.11 (python#97974)pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)pythongh-86482: Document assignment expression need for ()s (python#23291)pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
carljm added a commit to carljm/cpython that referenced this pull requestOct 8, 2022
* main:pythonGH-97002: Prevent `_PyInterpreterFrame`s from backing more than one `PyFrameObject` (pythonGH-97996)pythongh-97973: Return all necessary information from the tokenizer (pythonGH-97984)fixespythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)pythongh-97850: Remove the open issues section from the import reference (python#97935) Docs: pin sphinx-lint (pythonGH-97992)pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591) Add Pynche's move to the What's new in 3.11 (python#97974)pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)pythongh-86482: Document assignment expression need for ()s (python#23291)pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
mpage pushed a commit to mpage/cpython that referenced this pull requestOct 11, 2022
…thodcaller (python#94591)These were intentionally skipped when operator was updated to use the argument clinic:python#64385 (comment)However, by not using the argument clinic, they missed out on getting signatures.This is a narrow PR to update the docstrings so that `__text_signature__` can beextracted from them. Updating to use the argument clinic is beyond scope.`methodcaller` uses `*args, **kwargs` to match variadic names used elsewhere,including in `operator.call`.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#94590
These functions were intentionally skipped when operator was updated to use the argument clinic:
#64385 (comment)
However, by not using the argument clinic, they missed out on getting signatures. This is a narrow PR to update the docstrings so that
__text_signature__can be extracted from them. Updating to use the argument clinic is beyond scope.methodcalleruses*args, **kwargsto match variadic names used elsewhere (e.g.,operator.calluses*args, **kwargs).These changes are pretty minimal. Should I add tests (if so, where?) or a blurb?