Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-93963: Remove deprecated names from importlib.abc.#94528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
3574e94
to96f14c2
Comparejaraco commentedJul 24, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I've fileda Github support ticket to report the issue to Github and get their opinion on it. In the meantime,17f614e should work around the issue. |
Looks like probably only you@jaraco can see that ticket. |
@jaraco I'm trying to reboot myself on this discussion.@jaraco was the deprecation of access to these ABCs ever documented as deprecated in the library docs? I can't find that. That's not to say that it should hold up removal of these, since the deprecation warnings happened in the code. If we go ahead and remove the b/c hack now, I do think that any documentation update to |
jaraco commentedJul 29, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yeah, that's true. That's how Github does things. I linked it here to be transparent about what I'm doing and to associate a reference. Still no response, BTW.
I did not previously include that effort as part of this change because Hugo and others were working on docs updates. The deprecations were subsequently documented in#94546. |
CAM-Gerlach commentedDec 15, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hey@jaraco , what are the next steps here? Just FYI, following what was discussed inpython/core-workflow#475 , this is the only personal feature branch remaining on the upstream |
Let's close this and delete the branch and hope someone can find the changes when the time comes to submit it. |
Re-done as#119720. |
Uh oh!
There was an error while loading.Please reload this page.