Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-93963: Remove deprecated names from importlib.abc.#94528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

jaraco
Copy link
Member

@jaracojaraco commentedJul 3, 2022
edited
Loading

@jaracojaraco changed the base branch frommain togh-93963/deprecate-importlib-resources-abcsJuly 3, 2022 14:51
@jaracojaracoforce-pushed thegh-93963/remove-importlib-resources-abcs branch from3574e94 to96f14c2CompareJuly 3, 2022 14:58
Base automatically changed fromgh-93963/deprecate-importlib-resources-abcs tomainJuly 3, 2022 19:17
@jaraco
Copy link
MemberAuthor

I see now in691a82a, Github did the wrong thing. Apparently, because this repo uses squash merge, thereby rewriting history, Git can't tell that the lines removed in96f14c2 were to be removed, and instead of complaining that there's a conflict, it just undid that change.

@jaraco
Copy link
MemberAuthor

jaraco commentedJul 24, 2022
edited
Loading

I've fileda Github support ticket to report the issue to Github and get their opinion on it. In the meantime,17f614e should work around the issue.

@warsaw
Copy link
Member

I've fileda Github support ticket

Looks like probably only you@jaraco can see that ticket.

jaraco reacted with thumbs up emoji

@warsaw
Copy link
Member

@jaraco I'm trying to reboot myself on this discussion.@jaraco was the deprecation of access to these ABCs ever documented as deprecated in the library docs? I can't find that. That's not to say that it should hold up removal of these, since the deprecation warnings happened in the code. If we go ahead and remove the b/c hack now, I do think that any documentation update toimportlib.resources.abc should explicitly mention the deprecation and removal history of access throughimportlib.abc.

@jaraco
Copy link
MemberAuthor

jaraco commentedJul 29, 2022
edited
Loading

Looks like probably only you@jaraco can see that ticket.

Yeah, that's true. That's how Github does things. I linked it here to be transparent about what I'm doing and to associate a reference. Still no response, BTW.

was the deprecation of access to these ABCs ever documented as deprecated in the library docs?

I did not previously include that effort as part of this change because Hugo and others were working on docs updates. The deprecations were subsequently documented in#94546.

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commentedDec 15, 2022
edited
Loading

Hey@jaraco , what are the next steps here?

Just FYI, following what was discussed inpython/core-workflow#475 , this is the only personal feature branch remaining on the upstreamcpython repo, which blocks the full implementation of the branch protection rule approved inpython/steering-council#144 that would avoid the issue where it is easy to push personal feature branches to the upstream by accident, either through the Git CLI or via GitHub's web Edit feature.

@jaraco
Copy link
MemberAuthor

Let's close this and delete the branch and hope someone can find the changes when the time comes to submit it.

CAM-Gerlach reacted with thumbs up emoji

@jaracojaraco closed thisDec 17, 2022
@jaracojaraco deleted the gh-93963/remove-importlib-resources-abcs branchDecember 17, 2022 16:24
@hugovk
Copy link
Member

Re-done as#119720.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@jaraco@warsaw@CAM-Gerlach@hugovk@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp