Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-78707: deprecate passing >1 argument toPurePath.[is_]relative_to()#94469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

barneygale
Copy link
Contributor

@barneygalebarneygale commentedJun 30, 2022•
edited by miss-islington
Loading

This bringsrelative_to() andis_relative_to() more in line with other pathlib methods likerename() andsymlink_to().

Resolves#78707.

Automerge-Triggered-By: GH:brettcannon

…ive_to()`This brings `relative_to()` and `is_relative_to()` more in line with otherpathlib methods like `rename()` and `symlink_to()`.
Copy link
Member

@brettcannonbrettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

While I support the idea, I think there are some ergonomic tweaks we can make the to new call signature. The docs also need deprecation warnings.

barneygale reacted with thumbs up emoji
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@barneygale
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

Copy link
Member

@brettcannonbrettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One change to make to use a newer deprecation mechanism, but otherwise LGTM!

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@barneygale
Copy link
ContributorAuthor

Will fix conflicts when#99031 lands.

brettcannon reacted with thumbs up emoji

@barneygalebarneygale marked this pull request as draftNovember 3, 2022 00:04
@barneygale
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@barneygale
Copy link
ContributorAuthor

Hey@JelleZijlstra, as Brett is winding down his involvement in pathlib, do you think you could review this, please? I ask because you commented on#78707 some time ago :) Thanks!

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A couple of documentation suggestions, and shall also include it in "What’s New In Python 3.12"> "Pending Removal in Python 3.14"?

https://docs.python.org/3.12/whatsnew/3.12.html#pending-removal-in-python-3-14

These will help increase visibility for users.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@netlify
Copy link

netlifybot commentedDec 6, 2022•
edited
Loading

✅ Deploy Preview forpython-cpython-preview ready!

NameLink
🔨 Latest commit0374a35
🔍 Latest deploy loghttps://app.netlify.com/sites/python-cpython-preview/deploys/638fc037932d91000ada8424
😎 Deploy Previewhttps://deploy-preview-94469--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@barneygale
Copy link
ContributorAuthor

Thank you for the feedback!

hugovk reacted with thumbs up emoji

@miss-islingtonmiss-islington merged commit5a991da intopython:mainDec 17, 2022
shihai1991 added a commit to shihai1991/cpython that referenced this pull requestDec 18, 2022
* origin/main: (1306 commits)  CorrectCVE-2020-10735 documentation (python#100306)pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273)pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551)  Docs: Use `PY_VERSION_HEX` for version comparison (python#100179)pythongh-97909: Fix markup for `PyMethodDef` members (python#100089)pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205)pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469)pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541)pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168)pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302)  "Compound statement" docs: Fix with-statement step indexing (python#100286)pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278)  Improve stats presentation for calls. (pythonGH-100274)  Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295)pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277)  Document that zipfile's pwd parameter is a `bytes` object (python#100209)pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271)  Fix typo in introduction.rst (python#100266)  ...
carljm added a commit to carljm/cpython that referenced this pull requestDec 19, 2022
* main:pythongh-89727: Fix os.walk RecursionError on deep trees (python#99803)  Docs: Don't upload CI artifacts (python#100330)pythongh-94912: Added marker for non-standard coroutine function detection (python#99247)  CorrectCVE-2020-10735 documentation (python#100306)pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273)pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551)  Docs: Use `PY_VERSION_HEX` for version comparison (python#100179)pythongh-97909: Fix markup for `PyMethodDef` members (python#100089)pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205)pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

@brettcannonbrettcannonbrettcannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path.relative_to() taking multiple arguments could be better documented
5 participants
@barneygale@bedevere-bot@brettcannon@hugovk@miss-islington
[8]ページ先頭
©2009-2025 Movatter.jp