Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-94192: Fix error for dictionary literals with invalid expression as value.#94304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 2 commits intopython:mainfromwookie184:fix-dict-error
Jun 26, 2022

Conversation

wookie184
Copy link
Contributor

Closes#94192

I just added&('}'|',') which is the same as what was already done on line 1312. I couldn't think of any cases this makes worse and the existing tests seemed to run the same so I think this should be fine.

@wookie184
Copy link
ContributorAuthor

Should've run patchcheck 😅

@pablogsal
Copy link
Member

Thanks a lot for the PR@wookie184♥️

@pablogsalpablogsal merged commit8c237a7 intopython:mainJun 26, 2022
@miss-islington
Copy link
Contributor

Thanks@wookie184 for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 26, 2022
…sion as value. (pythonGH-94304)* Fix error for dictionary literals with invalid expression as value.* Remove trailing whitespace(cherry picked from commit8c237a7)Co-authored-by: wookie184 <wookie1840@gmail.com>
@miss-islington
Copy link
Contributor

Sorry,@wookie184 and@pablogsal, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 8c237a7a71d52f996f58dc58f6b6ce558d209494 3.10

@bedevere-bot
Copy link

GH-94308 is a backport of this pull request to the3.11 branch.

@pablogsal
Copy link
Member

@wookie184 Can you do the backport to 3.10 using cherry-picker?

wookie184 reacted with thumbs up emoji

miss-islington added a commit that referenced this pull requestJun 26, 2022
…s value. (GH-94304)* Fix error for dictionary literals with invalid expression as value.* Remove trailing whitespace(cherry picked from commit8c237a7)Co-authored-by: wookie184 <wookie1840@gmail.com>
wookie184 added a commit to wookie184/cpython that referenced this pull requestJun 27, 2022
… expression as value. (pythonGH-94304)* Fix error for dictionary literals with invalid expression as value.* Remove trailing whitespace.(cherry picked from commit8c237a7)Co-authored-by: wookie184 <wookie1840@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelJun 27, 2022
@bedevere-bot
Copy link

GH-94344 is a backport of this pull request to the3.10 branch.

pablogsal pushed a commit that referenced this pull requestJun 27, 2022
…ssion as value. (GH-94304) (#94344)Co-authored-by: wookie184 <wookie1840@gmail.com>
@wookie184wookie184 deleted the fix-dict-error branchJune 27, 2022 18:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalpablogsal approved these changes

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees

@pablogsalpablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A SyntaxError less detailed since 3.10 in specific example
4 participants
@wookie184@pablogsal@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp