Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-90016: Deprecate default sqlite3 adapters and converters#94276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJun 25, 2022•
edited
Loading

Closesgh-90016

@erlend-aasland
Copy link
ContributorAuthor

cc.@iafisher: would you mind reviewing this?

Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@erlend-aasland , and sorry for the delay! Just a handful of textual and reST/Sphinx fixes/suggestions.

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Again, +1 to most of Cam's thoughts

@erlend-aasland
Copy link
ContributorAuthor

Reviews addressed ind3dd3b4

Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks@erlend-aasland ! Just two minor fixes, both my mistake.

erlend-aasland reacted with thumbs up emoji
Erlend Egeberg Aaslandand others added2 commitsJuly 2, 2022 08:34
…409s.rstCo-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@erlend-aasland
Copy link
ContributorAuthor

@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters?

@serhiy-storchaka and@malemburg, would you two mind reviewing this?

@felixxm
Copy link
Contributor

@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters?

Yes, it works for us 👍 Thanks for letting me know 🎁 . I prepared PR with missing adapters/converters for Django, seedjango/django#15815.

erlend-aasland reacted with hooray emoji

Copy link
Contributor

@felixxmfelixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@erlend-aasland Thanks 👍

@erlend-aasland
Copy link
ContributorAuthor

I'll resolve the conflicts and land this PR later tonight.

CAM-Gerlach reacted with thumbs up emoji

@erlend-aaslanderlend-aasland merged commit6dadf6c intopython:mainJul 20, 2022
@erlend-aaslanderlend-aasland deleted the sqlite-deprecate-adapters branchJuly 20, 2022 19:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

@malemburgmalemburgAwaiting requested review from malemburg

+2 more reviewers

@iafisheriafisheriafisher left review comments

@felixxmfelixxmfelixxm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate default converters in sqlite3

6 participants

@erlend-aasland@felixxm@iafisher@CAM-Gerlach@AlexWaygood@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp