Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-94026: Buffer regrtest worker stdout in temporary file (GH-94253)#94253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tiran merged 3 commits intopython:mainfromtiran:gh-94026-tmpfile
Jun 29, 2022

Conversation

@tiran
Copy link
Member

@tirantiran commentedJun 25, 2022
edited by bedevere-bot
Loading

@tiran
Copy link
MemberAuthor

@vstinner are you ok with my patch?

@tirantiran added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJun 28, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@tiran for commit df2f3fbb63b946f5e709262c37cfad76d7372158 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJun 28, 2022
@tiran
Copy link
MemberAuthor

@vstinner please take a look. I would like to merge the PR today.

@vstinner
Copy link
Member

The overall change LGTM. I added a few comments.

IMO it's ok to use a temporary file to worker process stdout and stderr. If we can any issue later, we can reconsider this choice later. But so far, buildbots are happy, so I'm happy as well :-)

tiran reacted with thumbs up emoji

@tirantiran changed the titlegh-94026: Buffer regrtest worker stdout in temporary filegh-94026: Buffer regrtest worker stdout in temporary file (GH-94253)Jun 29, 2022
@tirantiran merged commit199ba23 intopython:mainJun 29, 2022
@tirantiran deleted the gh-94026-tmpfile branchJune 29, 2022 08:05
@miss-islington
Copy link
Contributor

Thanks@tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@tiran, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 199ba233248ab279f445e0809c2077976f0711bc 3.11

tiran added a commit to tiran/cpython that referenced this pull requestJun 29, 2022
pythonGH-94253)Co-authored-by: Victor Stinner <vstinner@python.org>.(cherry picked from commit199ba23)Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJun 29, 2022
@bedevere-bot
Copy link

GH-94408 is a backport of this pull request to the3.11 branch.

tiran added a commit that referenced this pull requestJun 29, 2022
…94253) (GH-94408)Co-authored-by: Victor Stinner <vstinner@python.org>.Co-authored-by: Christian Heimes <christian@python.org>
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull requestJun 30, 2022
@tim-one
Copy link
Member

Since this was checked in, parallel regrtest runs (-j) on Windows always fail for me. They just die midstream, skipping loads of tests, but not in any reproducible place.

After a long time, I eventually figured out that this happens if, and only if,test_disutils is being run. Add-x test_distutils, and no problem. OTOH, runningtest_distutils by itself fails even with-j1:

C:\Code\Python\PCbuild>rt -q -j1 test_distutilsC:\Code\Python\PCbuild>"C:\Code\Python\PCbuild\amd64\python.exe"  -u -Wd -E -bb -m test  -j1 test_distutils0:00:00 Run tests in parallel using 1 child processes0:01:00 load avg: 0.00 running: test_distutils (60.0 sec)Warning -- regrtest worker thread failed: Traceback (most recent call last):Warning --   File "C:\Code\Python\Lib\test\libregrtest\runtest_mp.py", line 334, in runWarning --     mp_result = self._runtest(test_name)Warning --                 ^^^^^^^^^^^^^^^^^^^^^^^^Warning --   File "C:\Code\Python\Lib\test\libregrtest\runtest_mp.py", line 293, in _runtestWarning --     stdout = stdout_fh.read().strip()Warning --              ^^^^^^^^^^^^^^^^Warning --   File "C:\Code\Python\Lib\tempfile.py", line 483, in func_wrapperWarning --     return func(*args, **kwargs)Warning --            ^^^^^^^^^^^^^^^^^^^^^Warning --   File "<frozen codecs>", line 322, in decodeWarning -- UnicodeDecodeError: 'utf-8' codec can't decode byte 0x91 in position 3149: invalid start byte== Tests result: NO TEST RUN ==1 test omitted:    test_distutilsTotal duration: 1 min 17 secTests result: NO TEST RUN1 test omitted:    test_distutilsTotal duration: 55.8 secTests result: NO TEST RUN

All the failures have "something like that" in them, although in context an irrelevant test usuallyappears to be at fault, because this unhandled exception causes all sorts of other crud to get skipped, and then Windows usually dies when teardown code is trying to delete a file that's still in use by some other test.

I don't understand what the code is trying to do, so just note that all visible problems go away if, when stdout_fh is created, the encoding is set to"latin1".

@vstinner
Copy link
Member

Warning -- UnicodeDecodeError: 'utf-8' codec can't decode byte 0x91 in position 3149: invalid start byte

Issue now tracked by#95027

vstinner added a commit to vstinner/cpython that referenced this pull requestSep 2, 2023
vstinner added a commit to vstinner/cpython that referenced this pull requestSep 2, 2023
…onGH-94253)Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit199ba23)
vstinner added a commit that referenced this pull requestSep 3, 2023
…108820)* Revert "[3.11]gh-101634: regrtest reports decoding error as failed test (#106169) (#106175)"This reverts commitd5418e9.* Revert "[3.11]bpo-46523: fix tests rerun when `setUp[Class|Module]` fails (GH-30895) (GH-103342)"This reverts commitecb09a8.* Revert "gh-95027: Fix regrtest stdout encoding on Windows (GH-98492)"This reverts commitb2aa28e.* Revert "[3.11]gh-94026: Buffer regrtest worker stdout in temporary file (GH-94253) (GH-94408)"This reverts commit0122ab2.* Revert "Run Tools/scripts/reindent.py (GH-94225)"This reverts commitf0f3a42.* Revert "gh-94052: Don't re-run failed tests with --python option (GH-94054)"This reverts commit1347607.* Revert "[3.11]gh-84461: Fix Emscripten umask and permission issues (GH-94002) (GH-94006)"This reverts commit1073184.*gh-93353: regrtest checks for leaked temporary files (#93776)When running tests with -jN, create a temporary directory per processand mark a test as "environment changed" if a test leaks a temporaryfile or directory.(cherry picked from commite566ce5)*gh-93353: Fix regrtest for -jN with N >= 2 (GH-93813)(cherry picked from commit36934a1)*gh-93353: regrtest supports checking tmp files with -j2 (#93909)regrtest now also implements checking for leaked temporary files anddirectories when using -jN for N >= 2. Use tempfile.mkdtemp() tocreate the temporary directory. Skip this check on WASI.(cherry picked from commit4f85cec)*gh-84461: Fix Emscripten umask and permission issues (GH-94002)- Emscripten's default umask is too strict, seeemscripten-core/emscripten#17269- getuid/getgid and geteuid/getegid are stubs that always return 0  (root). Disable effective uid/gid syscalls and fix tests that use  chmod() current user.- Cannot drop X bit from directory.(cherry picked from commit2702e40)*gh-94052: Don't re-run failed tests with --python option (#94054)(cherry picked from commit0ff7b99)* Run Tools/scripts/reindent.py (#94225)Reindent files which were not properly formatted (PEP 8: 4 spaces).Remove also some trailing spaces.(cherry picked from commite87ada4)*gh-94026: Buffer regrtest worker stdout in temporary file (GH-94253)Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit199ba23)*gh-96465: Clear fractions hash lru_cache under refleak testing (GH-96689)Automerge-Triggered-By: GH:zware(cherry picked from commit9c8f379)*gh-95027: Fix regrtest stdout encoding on Windows (#98492)On Windows, when the Python test suite is run with the -jN option,the ANSI code page is now used as the encoding for the stdouttemporary file, rather than using UTF-8 which can lead to decodingerrors.(cherry picked from commitec1f6f5)*gh-98903: Test suite fails with exit code 4 if no tests ran (#98904)The Python test suite now fails wit exit code 4 if no tests ran. Itshould help detecting typos in test names and test methods.* Add "EXITCODE_" constants to Lib/test/libregrtest/main.py.* Fix a typo: "NO TEST RUN" becomes "NO TESTS RAN"(cherry picked from commitc76db37)*gh-100086: Add build info to test.libregrtest (#100093)The Python test runner (libregrtest) now logs Python build information like"debug" vs "release" build, or LTO and PGO optimizations.(cherry picked from commit3c89202)*bpo-46523: fix tests rerun when `setUp[Class|Module]` fails (#30895)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>(cherry picked from commit9953860)*gh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (#103927)This runs test_asyncio sub-tests in parallel using sharding from Cinder. This suite is typically the longest-pole in runs because it is a test package with a lot of further sub-tests otherwise run serially. By breaking out the sub-tests as independent modules we can run a lot more in parallel.After porting we can see the direct impact on a multicore system.Without this change:  Running make test is 5 min 26 secondsWith this change:  Running make test takes 3 min 39 secondsThat'll vary based on system and parallelism. On a `-j 4` run similar to what CI and buildbot systems often do, it reduced the overall test suite completion latency by 10%.The drawbacks are that this implementation is hacky and due to the sorting of the tests it obscures when the asyncio tests occur and involves changing CPython test infrastructure but, the wall time saved it is worth it, especially in low-core count CI runs as it pulls a long tail. The win for productivity and reserved CI resource usage is significant.Future tests that deserve to be refactored into split up suites to benefit from are test_concurrent_futures and the way the _test_multiprocessing suite gets run for all start methods. As exposed by passing the -o flag to python -m test to get a list of the 10 longest running tests.---------Co-authored-by: Carl Meyer <carl@oddbird.net>Co-authored-by: Gregory P. Smith <greg@krypto.org> [Google, LLC](cherry picked from commit9e011e7)* Display the sanitizer config in the regrtest header. (#105301)Display the sanitizers present in libregrtest.Having this in the CI output for tests with the relevant environmentvariable displayed will help make it easier to do what we need tocreate an equivalent local test run.(cherry picked from commit852348a)*gh-101634: regrtest reports decoding error as failed test (#106169)When running the Python test suite with -jN option, if a worker stdoutcannot be decoded from the locale encoding report a failed testn so theexitcode is non-zero.(cherry picked from commit2ac3eec)*gh-108223: test.pythoninfo and libregrtest log Py_NOGIL (#108238)Enable with --disable-gil --without-pydebug:    $ make pythoninfo|grep NOGIL    sysconfig[Py_NOGIL]: 1    $ ./python -m test    ...    == Python build: nogil debug    ...(cherry picked from commit5afe0c1)*gh-90791: test.pythoninfo logs ASAN_OPTIONS env var (#108289)* Cleanup libregrtest code logging ASAN_OPTIONS.* Fix a typo on "ASAN_OPTIONS" vs "MSAN_OPTIONS".(cherry picked from commit3a1ac87)*gh-108388: regrtest splits test_asyncio package (#108393)Currently, test_asyncio package is only splitted into sub-tests whenusing command "./python -m test". With this change, it's alsosplitted when passing it on the command line:"./python -m test test_asyncio".Remove the concept of "STDTESTS". Python is now mature enough to nothave to bother with that anymore. Removing STDTESTS simplify thecode.(cherry picked from commit174e9da)* regrtest computes statistics (#108793)test_netrc, test_pep646_syntax and test_xml_etree now return resultsin the test_main() function.Changes:* Rewrite TestResult as a dataclass with a new State class.* Add test.support.TestStats class and Regrtest.stats_dict attribute.* libregrtest.runtest functions now modify a TestResult instance  in-place.* libregrtest summary lists the number of run tests and skipped  tests, and denied resources.* Add TestResult.has_meaningful_duration() method.* Compute TestResult duration in the upper function.* Use time.perf_counter() instead of time.monotonic().* Regrtest: rename 'resource_denieds' attribute to 'resource_denied'.* Rename CHILD_ERROR to MULTIPROCESSING_ERROR.* Use match/case syntadx to have different code depending on the  test state.Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>(cherry picked from commitd4e534c)*gh-108822: Add Changelog entry for regrtest statistics (#108821)---------Co-authored-by: Christian Heimes <christian@python.org>Co-authored-by: Zachary Ware <zach@python.org>Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Joshua Herman <zitterbewegung@gmail.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

Assignees

@tirantiran

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran@bedevere-bot@vstinner@miss-islington@tim-one

[8]ページ先頭

©2009-2025 Movatter.jp