NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-93096: Remove`python -m base64 -t`#94230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

corona10 merged 8 commits intopython:mainfromarhadthedev:remove-base64-cli

Jul 2, 2022

Merged

gh-93096: Remove`python -m base64 -t`#94230

corona10 merged 8 commits intopython:mainfromarhadthedev:remove-base64-cli

Jul 2, 2022

Conversation

Copy link

Member

arhadthedev commentedJun 24, 2022•
edited
Loading

test_base64.LegacyBase64TestCase.test_encodebytes/test_decodebytes is a more advanced version of the removed CLI argument.

The removed feature brings no benefit to an end user (unlike the rest ofpython -m base64).

Issue:Decide the fate of undocumented script behavior of some modules #93096

Removepython -m base64 -t

1fbaa63

bedevere-bot added the awaiting review label

Jun 24, 2022

arhadthedev mentioned this pull request

Jun 24, 2022

Decide the fate of undocumented script behavior of some modules#93096

Open

27 tasks

arhadthedev added4 commits

June 24, 2022 19:45

Make a changelog entry stronger.

5c6ff7c

Remove an associated test

cc58d75

Merge branch 'main' into remove-base64-cli

0174f60

Return get_output back

16d3dcc

corona10 requested changes

Jul 2, 2022

View reviewed changes

Lib/test/test_base64.pyShow resolvedHide resolved

bedevere-bot added awaiting changes and removed awaiting review labels

Jul 2, 2022

Copy link

bedevere-bot commentedJul 2, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.