Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.5k
[3.10] gh-93021: Fix __text_signature__ for __get__ (GH-93023)#94086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Because of the way wrap_descr_get is written, the second argumentto __get__ methods implemented through the wrapper is alwaysoptional.(cherry picked from commit4e08fbc)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
ContributorAuthor
miss-islington commentedJun 21, 2022
Status check is done, and it's a success ✅ . |
ContributorAuthor
miss-islington commentedJun 21, 2022
Status check is done, and it's a success ✅ . |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the way wrap_descr_get is written, the second argument
toget methods implemented through the wrapper is always
optional.
(cherry picked from commit4e08fbc)
Co-authored-by: Jelle Zijlstrajelle.zijlstra@gmail.com