Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-93963: Officially deprecate abcs and warn about their usage.#93965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jaraco
Copy link
Member

@jaracojaraco commentedJun 17, 2022
edited by miss-islington
Loading

@jaracojaraco added the needs backport to 3.11only security fixes labelJun 17, 2022
@jaracojaracoforce-pushed thegh-93963/deprecate-importlib-resources-abcs branch from2064d07 to7890672CompareJune 17, 2022 20:14
@jaracojaracoforce-pushed thegh-93963/deprecate-importlib-resources-abcs branch from7890672 to5e7fb9cCompareJune 17, 2022 20:23
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@hugovk
Copy link
Member

According toPEP 387, if these are being deprecated in 3.12, is 3.14 the earliest they can be removed?

Copy link
Member

@warsawwarsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added some questions.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@encukou
Copy link
Member

Honestly, I don't think all this is necessary. What would be the harm if they stay importable from both places?

@warsaw
Copy link
Member

Honestly, I don't think all this is necessary. What would be the harm if they stay importable from both places?

From a backward compatibility question, none. But we should be crisp in the documentation about where the proper place to import them from is, and add deprecations for the old places.

@jaraco
Copy link
MemberAuthor

According toPEP 387, if these are being deprecated in 3.12, is 3.14 the earliest they can be removed?

Yes, although I contend it would be preferable to deprecate these in 3.11 for removal in 3.13, given that is the prior intention.

@hugovk
Copy link
Member

Okay! I thought the3.11 beta period was too late for new deprecations, but let's check with@pablogsal to see if this can be backported to 3.11.

@pablogsal
Copy link
Member

Okay! I thought the3.11 beta period was too late for new deprecations, but let's check with@pablogsal to see if this can be backported to 3.11.

Indeed, unfortunately is too late to add new deprecations to 3.11, specially given how unstable 3.11 is already. Sadly this needs to be done starting in 3.12 :(

jaraco and ambv reacted with thumbs up emoji

@jaracojaraco removed the needs backport to 3.11only security fixes labelJul 3, 2022
@jaraco
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.

@miss-islingtonmiss-islington merged commit71848c9 intomainJul 3, 2022
@miss-islingtonmiss-islington deleted the gh-93963/deprecate-importlib-resources-abcs branchJuly 3, 2022 19:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@graingertgraingertgraingert left review comments

@hugovkhugovkhugovk requested changes

@warsawwarsawwarsaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Officially deprecate and remove abcs in importlib.abc moved to importlib.resources.
8 participants
@jaraco@hugovk@bedevere-bot@encukou@warsaw@pablogsal@graingert@miss-islington

[8]ページ先頭

©2009-2025 Movatter.jp