Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-93600: Clarify the meaning of buffering=-1 in open()#93685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
eamanu wants to merge13 commits intopython:main
base:main
Choose a base branch
Loading
fromeamanu:fix-93600

Conversation

eamanu
Copy link
Contributor

@eamanueamanu commentedJun 10, 2022•
edited by bedevere-bot
Loading

This commit clarify the meaning of buffering=-1 in open() function. Add
this information in Docs and in source code docstring.

This commit clarify the meaning of buffering=-1 in open() function. Addthis information in Docs and in source code docstring.
@AA-Turner
Copy link
Member

I think you need to regenerate the frozen version of_io --make regen-all. That should hopefully fix CI.

A

Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Grammar, and a minor change from "default buffer size" to "default buffering policy" -- this ties in the following text and helps communicate that-1 is the same as passing no argument.

A

eamanuand others added7 commitsJune 10, 2022 20:06
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@eamanu
Copy link
ContributorAuthor

eamanu commentedJun 10, 2022•
edited
Loading

HI@AA-Turner thanks for the revision. I've just push some changes, I applied the your recommendations and I pushed a commit running clinic.py, I hope that fix the build :-)

Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, it did fix the build -- you need to re-wrap two lines though and then go through the regen dance again!

A

Copy link
Member

@merwokmerwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggest changes to minimize diff churn.
Lines shorter than the limit are no problem, and this keeps git history slightly more useful 🙂

eamanuand others added3 commitsAugust 9, 2022 07:19
Apply suggestion of@merwokCo-authored-by: Éric <merwok@netwok.org>
Apply suggestion of@merwokCo-authored-by: Éric <merwok@netwok.org>
Apply suggestion of@merwokCo-authored-by: Éric <merwok@netwok.org>
@eamanu
Copy link
ContributorAuthor

Ready thanks@merwok

@hugovkhugovk removed the needs backport to 3.10only security fixes labelApr 7, 2023
@erlend-aaslanderlend-aasland self-assigned thisJan 12, 2024
@hugovkhugovk added needs backport to 3.12only security fixes and removed 3.12only security fixes needs backport to 3.11only security fixes labelsApr 11, 2024
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.13bugs and security fixes labelMay 9, 2024
@willingc
Copy link
Contributor

Thanks@eamanu. It looks like the merge conflicts need to be resolved. Please ping me once they are updated. Thanks.

@hugovkhugovk removed the needs backport to 3.12only security fixes labelApr 10, 2025
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14bugs and security fixes labelMay 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@merwokmerwokmerwok left review comments

@AA-TurnerAA-TurnerAA-Turner requested changes

Assignees

@erlend-aaslanderlend-aasland

Labels
awaiting changesdocsDocumentation in the Doc dirneeds backport to 3.13bugs and security fixesneeds backport to 3.14bugs and security fixesskip newstopic-IO
Projects
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@eamanu@AA-Turner@willingc@merwok@hugovk@serhiy-storchaka@erlend-aasland@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp