Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-79579: Improve DML query detection in sqlite3#93623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
erlend-aasland merged 22 commits intopython:mainfromerlend-aasland:sqlite-rowcount/gh-79579-altJun 14, 2022
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
22 commits Select commitHold shift + click to select a range
c8bcf3b Add tests
erlend-aaslandd38e632 Modify pysqlite_check_remaining_sql to return char * iso. int
erlend-aasland7fcca68 Rename pysqlite_check_remaining_sql to lstrip_sql
erlend-aasland3061dc5 Use lstrip_sql() to strip comments and whitespace
erlend-aasland631f24d Adjust comment
erlend-aasland8f29283 Explicit comparison
erlend-aaslanda51cfe6 Add more tests
erlend-aaslandbf0e150 Fix bug in lstrip parser
erlend-aasland5918fbe Adjust NEWS
erlend-aaslandb45e5b5 Make test more messy
erlend-aaslandb0a7fbc Address Ma Lin's review
erlend-aasland61a81eb Reword comment
erlend-aaslande3fea31 Inline it
erlend-aaslandd6ce75c Further mess up messy test to increase code coverage
erlend-aasland7f7943f Increase code coverage
erlend-aaslandadcba2c Merge branch 'main' into sqlite-rowcount/gh-79579-alt
erlend-aaslande5fafc7 Rewrite lstrip_sql by borrowing from SQLite's parser
erlend-aasland7d7a654 Test code nit
erlend-aasland2e638a0 Harden test_rowcount_prefixed_with_comment test
erlend-aaslandb932e4f Simplify one test
erlend-aaslandca053d7 Fix ret value for invalid comments
erlend-aaslandc6fa9b2 Simplify
erlend-aaslandFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Make test more messy
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitb45e5b50fd71fce8e779550361662d91a03729cd
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.