Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-93610: Improve docs for importlib.resources#93611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 18 commits intopython:mainfromencukou:impres-docs
Jul 25, 2022

Conversation

encukou
Copy link
Member

@encukouencukou commentedJun 8, 2022•
edited by bedevere-bot
Loading

This PR aims to make importlib.resources docs more usable.
@jaraco, do these look reasonable?

Please, if you have suggestions for more improvements, use the issue (or another PR). This PR does not aim to make the docs perfect, just better.

@encukouencukou requested a review fromjaracoJune 8, 2022 17:27
@bedevere-botbedevere-bot added docsDocumentation in the Doc dir awaiting core review labelsJun 8, 2022
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nothing major:

A

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
@encukou
Copy link
MemberAuthor

Hm, I see the mistake I made here: I moved all ofimportlib.abc to a new file, but in reality that page should be split betweenimportlib.abc andimportlib.resources.abc.
One day I'll learn how this package works, but it's not today!

@encukou
Copy link
MemberAuthor

Here's a fix.
There's a remaining reference to aimportlib.abc.TraversableReader, which is undocumented and actually lives in the undocumented moduleimportlib.resources.simple, but declare that out of scope of this PR.

@AA-Turner
Copy link
Member

It might make sense to break outimportlib.abc to its own page, but out of scope for thisimportlib.resouces-specific PR.

A

@ambvambv added the needs backport to 3.11only security fixes labelJul 25, 2022
@ambvambv merged commitccd7c7a intopython:mainJul 25, 2022
@miss-islington
Copy link
Contributor

Thanks@encukou for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJul 25, 2022
@bedevere-bot
Copy link

GH-95247 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 25, 2022
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>(cherry picked from commitccd7c7a)Co-authored-by: Petr Viktorin <encukou@gmail.com>
ambv added a commit that referenced this pull requestJul 25, 2022
(cherry picked from commitccd7c7a)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@slatenyslatenyslateny left review comments

@AA-TurnerAA-TurnerAA-Turner approved these changes

@jaracojaracoAwaiting requested review from jaraco

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip newstopic-importlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@encukou@AA-Turner@miss-islington@bedevere-bot@slateny@ambv
[8]ページ先頭
©2009-2025 Movatter.jp