Movatterモバイル変換

bedevere-bot added awaiting core review and removed awaiting review labels

AA-Turner added skip issue needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

AA-Turner approved these changes

Copy link

Member

merwok commentedSep 29, 2022

Could you create a ticket to describe the issue and make it easier to track the fixes? Thanks

nanjekyejoannah removed the skip issue label

Oct 7, 2022

nanjekyejoannah reviewed

Oct 7, 2022

Outdated info about encoding in "datetime"#99032

Copy link

Contributor

nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree, maybe we need an issue to track this.

Copy link

ContributorAuthor

wjandrea commentedOct 14, 2022•
edited
Loading

@merwok @nanjekyejoannah I could open an issue, sure, I'm just not sure what to say beyond what I've written here. Maybe,

The docs say thatstrftime() will return an encoded string (i.e.bytes), but actually it returns a Unicode string as of Python 3.0 (i.e.str).

Actually, now that I think about it again, maybe it'd be better to change the warning from "may contain Unicode characters encoded ..." to "may contain non-ASCII characters." Say the word and I'll open an issue so we can discuss that.

Copy link

Member

merwok commentedOct 14, 2022

That’s just the process we follow to keep things manageable 🙂
A bug report doesn’t have to be very long, if the title is clear and the description tells clearly what the problem is, then we can apply labels to categorize the problem, note all versions that need a fix, people get notified about it, etc.
The issue describes the problem and the PR discussion can focus on the solution. That’s all!

Full details here:https://devguide.python.org/triage/issue-tracker/

wjandrea mentioned this pull request

Nov 2, 2022

Closed

Copy link

Contributor

Jason-Y-Z commentedNov 3, 2022

Thanks for the PR. I think you will need to include the issue number in your PR title :)

AlexWaygood changed the title~~docs: datetime: Encoding is no longer relevant~~gh-99033: datetime docs: Encoding is no longer relevant

Nov 3, 2022

AlexWaygood changed the title~~gh-99033: datetime docs: Encoding is no longer relevant~~gh-99032: datetime docs: Encoding is no longer relevant

Nov 3, 2022

hugovk removed the needs backport to 3.10only security fixes label

Apr 7, 2023

pganssle requested changes

Doc/library/datetime.rst OutdatedShow resolvedHide resolved

bedevere-bot added awaiting changes and removed awaiting core review labels

Copy link

bedevere-bot commentedApr 24, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Update Doc/library/datetime.rst

8754eff

pganssle approved these changes

bedevere-bot removed the awaiting changes label

bedevere-bot added the awaiting merge label

Merge branch 'main' into patch-2

2d3d97c

abalkin approved these changes

Copy link

Member

abalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

pganssle merged commit2aa22f7 intopython:main

Copy link

Contributor

miss-islington commentedApr 24, 2023

Thanks@wjandrea for the PR, and@pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-99032: datetime docs: Encoding is no longer relevant (python…

50c797a

…GH-93365)This removes a section of the `strftime` and `strptime` documentation that refers to a bygone era when `strftime` would return an encoded byte string.---------(cherry picked from commit2aa22f7)Co-authored-by: William Andrea <william.j.andrea@gmail.com>Co-authored-by: Paul Ganssle <1377457+pganssle@users.noreply.github.com>

Copy link

bedevere-bot commentedApr 24, 2023

GH-103788 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

wjandrea deleted the patch-2 branch

April 24, 2023 19:00

carljm added a commit to carljm/cpython that referenced this pull request

Merge branch 'main' into superopt

19b8025

* main: (53 commits)pythongh-102498 Clean up unused variables and imports in the email module  (python#102482)pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244)pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365)pythongh-94300: Update datetime.strptime documentation (python#95318)pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778)pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456)pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775)  Revert "Add tests for empty range equality (python#103751)" (python#103770)pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519)pythonGH-65022: Fix description of copyreg.pickle function (python#102656)pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324)pythongh-91687: modernize dataclass example typing (python#103773)pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747)pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769)pythongh-87452: Improve the Popen.returncode docs  Removed unnecessary escaping of asterisks (python#103714)pythonGH-102973: Slim down Fedora packages in the dev container (python#103283)pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095)  Add tests for empty range equality (python#103751)pythongh-103712: Increase the length of the type name in AttributeError messages (python#103713)  ...

carljm added a commit to carljm/cpython that referenced this pull request