remove the unuseddetailed formatter in theconfig_initial dictionary;
modify the implementation of thehandle method of theMyHandler class to consider the loggers' levels in theconfig_listener dictionary.

bedevere-bot added the docsDocumentation in the Doc dir label

Sep 14, 2018

the-knights-who-say-ni added the CLA signed label

Sep 14, 2018

bedevere-bot added the awaiting review label

Sep 14, 2018

vsajip added skip issue skip news labels

Sep 15, 2018

Copy link

Member

vsajip commentedSep 15, 2018

Please revert the whitespace /PEP-8 changes, which are not applicable to the specific example we discussed. Just keep the changes within the specific example script.

vsajip changed the title~~Improve the more elaborate multiprocessing example~~Improve the more elaborate multiprocessing example in the logging cookbook

Sep 15, 2018

Improve the more elaborate multiprocessing example in the logging coo…

0f54858

…kbook* Remove the unused detailed formatter in the config_initial dictionary.* Modify the implementation of the  method of the MyHandler class to consider the loggers' levels in the config_listener dictionary.

geryogam force-pushed thepatch-1 branch from64fa52b to0f54858Compare

September 15, 2018 15:41

Copy link

ContributorAuthor

geryogam commentedSep 15, 2018

@vsajip

Please revert the whitespace / PEP-8 changes, which are not applicable to the specific example we discussed. Just keep the changes within the specific example script.

Done.

Copy link

Member

OK, thanks. Just as a general suggestion - please avoid making stylistic changes which aren't specific to the issue being addressed. For example, you have re-ordered some dictionary keys, added blank lines and removed trailing commas, where none of these changes were needed in order to (a) remove the unused formatter and (b) respect the logger level while dispatching events. While I'm not asking you to revert these, it's generally best to minimise noise in PRs - because it makes life easier for reviewers not to have to review stylistic changes which have no impact on the functionality changes being addressed.