Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-93243: Make smtpd private before porting its users#93246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
miss-islington merged 19 commits intopython:mainfromarhadthedev:privatize-smtpd
Aug 6, 2022

Conversation

@arhadthedev
Copy link
Member

@arhadthedevarhadthedev commentedMay 26, 2022•
edited by miss-islington
Loading

gh-93243

This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smtpd in a single PR).

Automerge-Triggered-By: GH:warsaw

Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some docs/wording comments:

A

arhadthedevand others added4 commitsJune 4, 2022 19:01
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@hugovk
Copy link
Member

cc alsoPEP-594 co-author@brettcannon.

Copy link
Member

@brettcannonbrettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@arhadthedev
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@arhadthedev
Copy link
MemberAuthor

arhadthedev commentedJul 29, 2022•
edited
Loading

Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.

@vsajip@warsaw could you review and possibly merge this PR please? It deletessmtpd tests in advance and, for consistency, makes the module private by moving it intoLib/test/smtpd.py.

This is necessary to allow further reviewable-sized PRs (one for eachSMTP* classmoved into its consumer intest) without massive changes ofLib/test/test_smtpd.py for synchronization.

Copy link
Member

@warsawwarsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have a small rewording request.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@arhadthedev
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon,@warsaw: please review the changes made to this pull request.

Wording suggestion.
@brettcannon
Copy link
Member

@warsaw not sure if this is showing up in your review queue as the GH UI is not letting me re-request your review.

Small reword suggestion.
@warsaw
Copy link
Member

Thanks for the ping@brettcannon - I'm good with this, with my one edit to the source branch. I thought I'd pushed that through previously, but upon further review, it doesn't look like it stuck. Trying that again...

Copy link
Member

@warsawwarsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Okay, this time it looks like my small wording edit got committed. Thanks for the contribution@arhadthedev ! Approving and setting theautomerge label.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅ .

@miss-islingtonmiss-islington merged commit56d16e8 intopython:mainAug 6, 2022
@arhadthedevarhadthedev deleted the privatize-smtpd branchAugust 7, 2022 06:55
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull requestAug 11, 2022
…-93246)pythongh-93243This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smtpd in a single PR).Automerge-Triggered-By: GH:warsaw
@hugovkhugovk mentioned this pull requestOct 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments

@AA-TurnerAA-TurnerAA-Turner left review comments

@warsawwarsawwarsaw approved these changes

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

@brettcannonbrettcannonAwaiting requested review from brettcannon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@arhadthedev@hugovk@bedevere-bot@brettcannon@warsaw@miss-islington@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp