Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-93205: When rotating logs with no namer specified, match whole extension#93224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ilCatania
Copy link
Contributor

@ilCataniailCatania commentedMay 25, 2022•
edited
Loading

FixesGH-93205: When setting up multiple logging handlers of typeTimedRotatingFileHandler that log to the same directory and only differ by the file extension, rollover does not work properly for either of them.

There have been a few changes inTimeRotatingHandler (GH-90221,GH-89791) due to different file format expectations when a namer is specified versus not specified. This PR fixes the issue inGH-93205 while trying to simplify the code.

@ilCataniailCatania requested a review fromvsajip as acode ownerMay 25, 2022 17:35
@ghost
Copy link

ghost commentedMay 25, 2022•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@serhiy-storchakaserhiy-storchaka changed the titlegh-93205 when rotating logs with no namer specified, match whole extensiongh-93205: When rotating logs with no namer specified, match whole extensionFeb 21, 2024
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

I agree that it is better to separate simpler case with no namer, where the matches can be found unambiguous and more efficiently from more complex case with helper.

It is still not completely unambiguous and can conflict with other TimedRotatingFileHandler with a namer that simply adds an extension, but I'm going to fix this in other issue.

ilCatania reacted with rocket emoji
@serhiy-storchakaserhiy-storchaka merged commit113687a intopython:mainFeb 21, 2024
@miss-islington-app
Copy link

Thanks@ilCatania for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 21, 2024
…le extension (pythonGH-93224)(cherry picked from commit113687a)Co-authored-by: Gabriele Catania <gabriele.ctn@gmail.com>
@bedevere-app
Copy link

GH-115784 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelFeb 21, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 21, 2024
…le extension (pythonGH-93224)(cherry picked from commit113687a)Co-authored-by: Gabriele Catania <gabriele.ctn@gmail.com>
@bedevere-app
Copy link

GH-115785 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelFeb 21, 2024
serhiy-storchaka pushed a commit that referenced this pull requestFeb 21, 2024
…ole extension (GH-93224) (GH-115784)(cherry picked from commit113687a)Co-authored-by: Gabriele Catania <gabriele.ctn@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull requestFeb 21, 2024
…ole extension (GH-93224) (GH-115785)(cherry picked from commit113687a)Co-authored-by: Gabriele Catania <gabriele.ctn@gmail.com>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull requestMar 4, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull requestJan 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple TimedRotatingFileHandler with similar names but different backup counts do not work

4 participants

@ilCatania@bedevere-bot@serhiy-storchaka@vsajip
[8]ページ先頭
©2009-2025 Movatter.jp