Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
bpo-44530: Document the change in MAKE_FUNCTION behavior#93189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fixes dis module documentation for MAKE_FUNCTION due topython@2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS
ghost commentedMay 24, 2022 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
bedevere-bot commentedMay 24, 2022
Most changes to Pythonrequire a NEWS entry. Please add it using theblurb_it web app or theblurb command-line tool. |
kumaraditya303 commentedJun 14, 2022
Trigger CI |
kumaraditya303 commentedJun 14, 2022
@alexdoesh There are trailing whitespaces hence CI is failing. |
stefanor commentedDec 6, 2022
I just came past to file the same MR. LGTM. |
stefanor commentedDec 6, 2022
I guess an update in "what's new" would be handy, too. |
williamwen42 commentedJan 10, 2023
What's the status on this PR? I encountered this exact issue -- MAKE_FUNCTION behavior is different than what is documented. |
Barkhat26 commentedJun 13, 2023
Maybe, it is need to finally code review and pull this PR? Because there is the same docs error in newer python versions |
* main: (3912 commits)pythongh-105831: Fix NEWS blurb frompythongh-105828 (python#105833)pythongh-105820: Fix tok_mode expression buffer in file & readline tokenizer (python#105828)pythongh-105751, test_ctypes: Remove disabled tests (python#105826)pythongh-105821: Use a raw f-string in test_httpservers.py (python#105822)pythongh-105751: Remove platform usage in test_ctypes (python#105819)pythongh-105751: Reenable disable test_ctypes tests (python#105818)pythongh-105751: Remove dead code in test_ctypes (python#105817) More reorganisation of the typing docs (python#105787) Improve docs for `typing.dataclass_transform` (python#105792)pythonGH-89812: Churn `pathlib.Path` test methods (python#105807)pythongh-105800: Issue SyntaxWarning in f-strings for invalid escape sequences (python#105801)pythongh-105751: Cleanup test_ctypes imports (python#105803)pythongh-105481: add HAS_JUMP flag to opcode metadata (python#105791)pythongh-105751: test_ctypes avoids the operator module (pythonGH-105797)pythongh-105751: test_ctypes: Remove @need_symbol decorator (pythonGH-105798)pythongh-104909: Implement conditional stack effects for macros (python#105748)pythongh-75905: Remove test_xmlrpc_net: skipped since 2017 (python#105796)pythongh-105481: Fix types and a bug for pseudos (python#105788) Update DSL docs for cases generator (python#105753)pythonGH-77273: Better bytecodes for f-strings (pythonGH-6132) ...
miss-islington commentedJun 16, 2023
Thanks@alexdoesh for the PR, and@carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington commentedJun 16, 2023
Thanks@alexdoesh for the PR, and@carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington commentedJun 16, 2023
Sorry,@alexdoesh and@carljm, I could not cleanly backport this to |
miss-islington commentedJun 16, 2023
Sorry@alexdoesh and@carljm, I had trouble checking out the |
miss-islington commentedJun 16, 2023
Thanks@alexdoesh for the PR, and@carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
)* bpo-44530: Document the change in MAKE_FUNCTION behaviorFixes dis module documentation for MAKE_FUNCTION due topython@2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS(cherry picked from commit486b52a)Co-authored-by: Alex Doe <alexdoesh@gmail.com>
bedevere-bot commentedJun 16, 2023
GH-105841 is a backport of this pull request to the3.12 branch. |
bedevere-bot commentedJun 16, 2023
GH-105842 is a backport of this pull request to the3.11 branch. |
…onGH-93189)* bpo-44530: Document the change in MAKE_FUNCTION behaviorFixes dis module documentation for MAKE_FUNCTION due topython@2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS.(cherry picked from commit486b52a)Co-authored-by: Alex Doe <alexdoesh@gmail.com>
…3189) (#105841)bpo-44530: Document the change in MAKE_FUNCTION behavior (GH-93189)*bpo-44530: Document the change in MAKE_FUNCTION behaviorFixes dis module documentation for MAKE_FUNCTION due to2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS(cherry picked from commit486b52a)Co-authored-by: Alex Doe <alexdoesh@gmail.com>
* main:pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846)pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835) CI: Remove docs build from Azure Pipelines (python#105823)pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851) Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969)pythongh-105433: Add `pickle` tests for PEP695 (python#105443) bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
* bpo-44530: Document the change in MAKE_FUNCTION behaviorFixes dis module documentation for MAKE_FUNCTION due topython@2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS
Fixes dis module documentation for MAKE_FUNCTION opcode accordingly tobpo-44530,2f180ce removes the qualified name at TOS in favor of
co_qualnameusage