NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-92888: memory_ass_sub() calls CHECK_RELEASED_INT() twice#93127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

vstinner wants to merge1 commit intopython:mainfromvstinner:release_view

Closed

gh-92888: memory_ass_sub() calls CHECK_RELEASED_INT() twice#93127

vstinner wants to merge1 commit intopython:mainfromvstinner:release_view

Conversation

Copy link

Member

vstinner commentedMay 23, 2022

If a memoryview is released while setting an item, raise an
exception. For example, converting an object to an index in C can
execute arbitrary Python code which can indirectly release the
memoryview.

gh-92888: memory_ass_sub() calls CHECK_RELEASED_INT() twice

14f423a

If a memoryview is released while setting an item, raise anexception. For example, converting an object to an index in C canexecute arbitrary Python code which can indirectly release thememoryview.

bedevere-bot added the awaiting core review label

May 23, 2022

Copy link

MemberAuthor

vstinner commentedMay 23, 2022

I chose to keep the CHECK_RELEASED_INT() call at memory_ass_sub() entry.

I guess that memory_subscript() suffers from the same issue: I would prefer to fix it in a separated PR, but maybe then we can combine the two changes when backporting to stable branches.