Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.3k
gh-89973: Fix re.error in the fnmatch module.#93072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 6 commits intopython:mainfromserhiy-storchaka:fnmatch-invalid-rangeJun 5, 2022
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
6 commits Select commitHold shift + click to select a range
ab4b759
gh-89973: Fix re.error in the fnmatch module.
serhiy-storchaka7be4e0b
Fix tests on Windows.
serhiy-storchaka9b65639
Update Misc/NEWS.d/next/Library/2022-05-22-16-08-01.gh-issue-89973.jc…
serhiy-storchakab1df922
Merge branch 'main' into fnmatch-invalid-range
serhiy-storchakad29d8af
Refactor.
serhiy-storchaka11d0e04
Merge branch 'fnmatch-invalid-range' of github.com:serhiy-storchaka/c…
serhiy-storchakaFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
gh-89973: Fix re.error in the fnmatch module.
Character ranges with upper bound less that lower bound are nowinterpreted as empty ranges, for compatibility with other globpattern implementations. Previously it was re.error.
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitab4b759a6f24c95548f4f37238fba93f342fa6d7
There are no files selected for viewing
23 changes: 17 additions & 6 deletionsLib/fnmatch.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletionsLib/test/test_fnmatch.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletionsMisc/NEWS.d/next/Library/2022-05-22-16-08-01.gh-issue-89973.jc-Q4g.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Fix :exc:`re.error` raised in :mod:`fnmatch` if the patterna contains | ||
character range with upeer bound lower than lower bound (e.g. ``[c-a]``). | ||
serhiy-storchaka marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
Now such ranges are interpreted as empty ranges. |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.