Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
[3.11] gh-92611: Clarify planned removal version in PEP 594-deprecated modules (GH-92793)#93026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… modules (pythonGH-92793)As discussed inpythonGH-92611 andpythonGH-92564 and as a followup to PRpythonGH-92612 , this 3.11+ only PR uses the proper `deprecated-removed` role for the modules deprecated by PEP 593 (PEP-594) to clearly indicate to users that a removal version is planned and what it is, so they can prepare accordingly or voice any unanticipated impacts.Related topythonGH-92792 ; if we decide to backport that PR, the upgrade to using `deprecated-removed` on those functions can be moved to this one.(cherry picked from commit31fa41e)Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
ContributorAuthor
miss-islington commentedMay 20, 2022
Status check is done, and it's a success ✅ . |
1 similar comment
ContributorAuthor
miss-islington commentedMay 20, 2022
Status check is done, and it's a success ✅ . |
brettcannon approved these changesMay 20, 2022
ContributorAuthor
miss-islington commentedMay 20, 2022
Status check is done, and it's a success ✅ . |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As discussed inGH-92611 andGH-92564 and as a followup to PRGH-92612 , this 3.11+ only PR uses the proper
deprecated-removedrole for the modules deprecated by PEP 593 (PEP-594) to clearly indicate to users that a removal version is planned and what it is, so they can prepare accordingly or voice any unanticipated impacts.Related toGH-92792 ; if we decide to backport that PR, the upgrade to using
deprecated-removedon those functions can be moved to this one.(cherry picked from commit31fa41e)
Co-authored-by: CAM GerlachCAM.Gerlach@Gerlach.CAM
Automerge-Triggered-By: GH:brettcannon