Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-93356: Lay out exception handling code at end of code unit#92769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
31 commits Select commitHold shift + click to select a range
586abbe emit except handlers at end of function
iritkatriel7cee46c remove redundant jumps after reordering cold blocks
iritkatriela1ab27d add some sanity checks
iritkatriel5cbffc2 fix test_dis and test_code
iritkatriel399a898 Merge remote-tracking branch 'upstream/main' into cold_code
iritkatriel30c85e3 update test_dis after merge
iritkatriel23b7b11 most tests pass
iritkatrielaabea44 abort if fallthrough from cold to warm block
iritkatriel521ca2c exclude generators and coroutines
iritkatriel57a7576 minor tidy up
iritkatrielfd94d0d mark cold/warm use block from assembler instead of compiler. code_fla…
iritkatriel4ab5905 Merge remote-tracking branch 'upstream/main' into cold_blocks_in_backend
iritkatriel4759a45 move mark_cold/warm to the new traversal style
iritkatrielcd644f0 fix a silly bug
iritkatriel3351114 replace cold->warm fallthrough by explicit jump
iritkatriel51f28c6 remove debug code
iritkatriel752e9a7 reverse unnecessary changes
iritkatriel3e3a34d Merge remote-tracking branch 'upstream/main' into cold_blocks_in_backend
iritkatriele719b0f fix merge error
iritkatriel60b433f use the new basicblock_add_jump
iritkatrieldc8949a fix test_dis again
iritkatriel7e5d1fb revert changes to Lib/importlib/_bootstrap_external.py
iritkatrieldcfb8a7 typo in comment
iritkatriel0f0f085 📜🤖 Added by blurb_it.
blurb-it[bot]d1baf48 use b_visited for 'pushed to sp' rather than for 'popped from sp'
iritkatrielaa52363 add missing null check
iritkatriel848c8b1 rewrite cold-block-reordering logic (hopefully easier to follow now)
iritkatrielbaedc8f Merge remote-tracking branch 'upstream/main' into cold_blocks_in_backend
iritkatriel44d4093 make regen
iritkatriel6a12c78 Revert "make regen"
iritkatriel6a454c8 Merge remote-tracking branch 'upstream/main' into cold_blocks_in_backend
iritkatrielFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
📜🤖 Added by blurb_it.
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit0f0f08562ecdd98179a4a4e1fb8b98acad302e4d
There are no files selected for viewing
1 change: 1 addition & 0 deletionsMisc/NEWS.d/next/Core and Builtins/2022-05-30-15-51-11.gh-issue-93356.l5wnzW.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Code for exception handlers is emitted at the end of the code unit's bytecode. This avoids one jump when no exception is raised. |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.