Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-61441: XML entity expansion limitation#9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
tiran wants to merge1 commit intopython:mainfromtiran:bpo17239-expat-limit

Conversation

@tiran
Copy link
Member

@tirantiran commentedSep 13, 2018•
edited by bedevere-appbot
Loading

@vstinner
Copy link
Member

I would prefer to see this change made in expat upstream. We should vendor an unmodified version of expat.

@tiran
Copy link
MemberAuthor

That's the plan.

@vstinnervstinner changed the titlebpo-17239: XML entity expansion limitation[WIP] bpo-17239: XML entity expansion limitationSep 13, 2018
@zooba
Copy link
Member

Since we ship the vendored one as part of the Windows release, I'd be happy to have this merged for 3.7.1 while we wait for the patch to go upstream.

This is not our public API, so even if they upstream a different version of it, that won't affect us.

@tirantiranforce-pushed thebpo17239-expat-limit branch 4 times, most recently from6a51752 to2cffc90CompareSeptember 20, 2018 11:30
Modelled afterhttps://github.com/GNOME/libxml2/blob/v2.9.8/parser.c#L99Signed-off-by: Christian Heimes <christian@python.org>
@matrixise
Copy link
Member

@tiran maybe we could close this issue, +- 1y and I supposeexpat has been updated.

@arhadthedev
Copy link
Member

@tiran Is the PR still relevant?

typedefstruct {
ENTITY*first_entity;
unsignedintentitiesNestingLevel;
size_tnestedEntitiesExpansionSize;/* in bytes, not XML_Cha) */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
size_tnestedEntitiesExpansionSize;/* in bytes, notXML_Cha) */
size_tnestedEntitiesExpansionSize;/* in bytes, notXML_Char */

arhadthedev reacted with thumbs up emoji
@erlend-aaslanderlend-aasland changed the title[WIP] bpo-17239: XML entity expansion limitationgh-61441: XML entity expansion limitationJan 4, 2024
@erlend-aaslanderlend-aasland marked this pull request as draftJanuary 4, 2024 10:14
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelDec 15, 2024
@gpshead
Copy link
Member

closing as external entity expansion was disabled in sax other PRs (see issue)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@disconnect3ddisconnect3ddisconnect3d left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DO-NOT-MERGEstaleStale PR or inactive for long period of time.type-securityA security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@tiran@vstinner@zooba@matrixise@arhadthedev@gpshead@disconnect3d@iritkatriel@the-knights-who-say-ni@ezio-melotti@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp