Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-92592: Allow logging filters to return a LogRecord. (GH-92591)#92591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
18 commits Select commitHold shift + click to select a range
3aeeba6 allow logging filters to return a LogRecord
adriangb1e4d27f edit docstring
adriangbb526a35 remove unecessary __bool__ impl
adriangbf1ea183 edit docs
adriangb19561d3 Add docs and blurb
adriangb14e704d Merge branch 'main' into logging-filters
adriangb4d34540 fix rst
adriangba69e76a touch up wording
adriangb67453f6 add test for filters on loggers
adriangbb1e1084 push straggler change
adriangbf72c594 Merge branch 'main' into logging-filters
adriangb225329f pr feedback
adriangb735d78a Merge branch 'logging-filters' of https://github.com/adriangb/cpython…
adriangb5e54c77 Merge branch 'main' into logging-filters
adriangbf52e404 fix whitespace
adriangb46e2f7f fix docs as per pr feedback
adriangb7a0f470 Update logging-cookbook.rst
vsajip643551d Update logging.rst
vsajipFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
fix docs as per pr feedback
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit46e2f7fbeeae2c124980c58efb453836eaa214d5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletionMisc/NEWS.d/next/Library/2022-05-09-22-27-11.gh-issue-92591.V7RCk2.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| Allow :mod:`logging` filters to return a :class:`logging.LogRecord` instance | ||
| so that filters attached to :class:`logging.Handler`\ s can enrich records without | ||
| side effects on other handlers. |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.