Feb 9, 2023 · Feb 5, 2023 · Feb 5, 2023 · Feb 6, 2023 · Feb 6, 2023 · Feb 6, 2023
diff --git a/Doc/whatsnew/3.12.rst b/Doc/whatsnew/3.12.rst
  :func:`~multiprocessing.set_start_method` APIs to explicitly specify when
  your code *requires* ``'fork'``.  See :ref:`multiprocessing-start-methods`.

 * :mod:`pty` has two undocumented ``master_open()`` and ``slave_open()``
  functions that have been deprecated since Python 2 but only gained a
  proper :exc:`DeprecationWarning` in 3.12. Remove them in 3.14.

 Pending Removal in Future Versions
 ----------------------------------

diff --git a/Lib/pty.py b/Lib/pty.py
    Open a pty master and return the fd, and the filename of the slave end.
    Deprecated, use openpty() instead."""

    import warnings
    warnings.warn("Use pty.openpty() instead.", DeprecationWarning, stacklevel=2)  # Remove API in 3.14

    try:
        master_fd, slave_fd = os.openpty()
    except (AttributeError, OSError):
    opened filedescriptor.
    Deprecated, use openpty() instead."""

    import warnings
    warnings.warn("Use pty.openpty() instead.", DeprecationWarning, stacklevel=2)  # Remove API in 3.14

    result = os.open(tty_name, os.O_RDWR)
    try:
        from fcntl import ioctl, I_PUSH
    master_fd, slave_fd = openpty()
    pid = os.fork()
    if pid == CHILD:
        # Establish a new session.
        os.setsid()
        os.close(master_fd)

        # Slave becomes stdin/stdout/stderr of child.
        os.dup2(slave_fd, STDIN_FILENO)
        os.dup2(slave_fd, STDOUT_FILENO)
        os.dup2(slave_fd, STDERR_FILENO)
        if slave_fd > STDERR_FILENO:
            os.close(slave_fd)

        # Explicitly open the tty to make it become a controlling tty.
        tmp_fd = os.open(os.ttyname(STDOUT_FILENO), os.O_RDWR)
        os.close(tmp_fd)
        os.login_tty(slave_fd)
    else:
        os.close(slave_fd)

diff --git a/Misc/NEWS.d/next/Library/2023-02-05-21-40-15.gh-issue-85984.Kfzbb2.rst b/Misc/NEWS.d/next/Library/2023-02-05-21-40-15.gh-issue-85984.Kfzbb2.rst
 Refactored the implementation of :func:`pty.fork` to use :func:`os.login_tty`.

 A :exc:`DeprecationWarning` is now raised by ``pty.master_open()`` and ``pty.slave_open()``. They were
 undocumented and deprecated long long ago in the docstring in favor of :func:`pty.openpty`.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -512,6 +512,10 @@ Pending Removal in Python 3.14
		:func:`~multiprocessing.set_start_method` APIs to explicitly specify when
		your code requires ``'fork'``. See :ref:`multiprocessing-start-methods`.

		* :mod:`pty` has two undocumented ``master_open()`` and ``slave_open()``
		functions that have been deprecated since Python 2 but only gained a
		proper :exc:`DeprecationWarning` in 3.12. Remove them in 3.14.

		Pending Removal in Future Versions
		----------------------------------

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -40,6 +40,9 @@ def master_open():
		Open a pty master and return the fd, and the filename of the slave end.
		Deprecated, use openpty() instead."""

		import warnings
		warnings.warn("Use pty.openpty() instead.", DeprecationWarning, stacklevel=2) # Remove API in 3.14

		try:
		master_fd, slave_fd = os.openpty()
		except (AttributeError, OSError):
Expand DownExpand Up		@@ -69,6 +72,9 @@ def slave_open(tty_name):
		opened filedescriptor.
		Deprecated, use openpty() instead."""

		import warnings
		warnings.warn("Use pty.openpty() instead.", DeprecationWarning, stacklevel=2) # Remove API in 3.14

		result = os.open(tty_name, os.O_RDWR)
		try:
		from fcntl import ioctl, I_PUSH
Expand DownExpand Up		@@ -101,20 +107,8 @@ def fork():
		master_fd, slave_fd = openpty()
		pid = os.fork()
		if pid == CHILD:
		# Establish a new session.
		os.setsid()
		os.close(master_fd)

		# Slave becomes stdin/stdout/stderr of child.
		os.dup2(slave_fd, STDIN_FILENO)
		os.dup2(slave_fd, STDOUT_FILENO)
		os.dup2(slave_fd, STDERR_FILENO)
		if slave_fd > STDERR_FILENO:
		os.close(slave_fd)

		# Explicitly open the tty to make it become a controlling tty.
		tmp_fd = os.open(os.ttyname(STDOUT_FILENO), os.O_RDWR)
		os.close(tmp_fd)
		os.login_tty(slave_fd)
		else:
		os.close(slave_fd)

Expand Down
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		Refactored the implementation of :func:`pty.fork` to use :func:`os.login_tty`.

		A :exc:`DeprecationWarning` is now raised by ``pty.master_open()`` and ``pty.slave_open()``. They were
		undocumented and deprecated long long ago in the docstring in favor of :func:`pty.openpty`.