@gpshead Please take a look at this when you have time.

Two changes are being made.

1. Remove code forpty.openpty() that uses the "old SGI method or the manual BSD open-a-pty code" that was marked as deprecated way back in year 2000 byThomas Wouters; this includespty.master_open(),pty._open_terminal(), andpty.slave_open(); these are not even in thetest_pty.py anymore.

2. Make the fallback code inpty.fork() useos.login_tty(). Please note that the replacement code inpty.fork() is different from the removed code in the following way.

• The removed code is using the legacySystem V method ofopen()-ing a tty device to make it a controlling terminal;
• The replacement code is usingos.login_tty(), which useslogin_tty(3) if available, or else uses theTIOCSCTTYioctl(), which evenSystem V derivatives support now:https://marc.info/?l=glibc-help&m=164436296715753&w=3

@asvetlov@ethanfurman@aeros please take a look if you have time as well.

@gpshead thank you for the review.

@kumaraditya303 thank you for the review request.

I have many other improvements planned (and to a large extent ready) for this module for which I will make pull requests once this is merged (after December since I am busy applying for postdocs now).

(I'm working my way through some PRs which have been approved and are labeled "awaiting merge", hence my seemingly bolt from the blue comment. Why?Read here.)

Maybe this didn't get addressed in the sprint? Is it ready to merge or does it need more work? If it needs more work, maybe theDO-NOT-MERGE label should be added.

@smontanaro Thank you for the review. This does not need more work unless@gpshead has any suggestions. This is a part of a series of PRs aimed at improving the pty library. A few have been merged before, and if this one gets merged, then I have more to follow, which I will work on right after December (I am still applying for postdocs).

@gpshead If/when you have time, please let me know if you need me to make any changes to this.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again.

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@gpshead Just realized that I had forgotten to add the deprecation warnings.
Thank you for adding them.

Refactored the implementation ofpty.fork to useos.login_tty.

ADeprecationWarning is now raised bypty.master_open() andpty.slave_open(). They were
undocumented and deprecated long long ago in the docstring in favor ofpty.openpty.