Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-91954: Use shell=True in test_subprocess.test_encoding_warning#92090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sweeneyde merged 2 commits intopython:mainfromsweeneyde:encoding_warnings
May 1, 2022

Conversation

@sweeneyde
Copy link
Member

@sweeneydesweeneyde commentedApr 30, 2022•
edited
Loading

This fixes failing AMD64 Windows buildbots, which were failing because on Windows,echo is a command, not a program.

@bedevere-botbedevere-bot added testsTests in the Lib/test dir awaiting core review labelsApr 30, 2022
@sweeneydesweeneyde changed the titletest_subprocess.test_encoding_warning: Use stderr as the assertion messagegh-91954: test_subprocess.test_encoding_warning: Use stderr as the assertion messageApr 30, 2022
@sweeneydesweeneyde added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 30, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@sweeneyde for commit4b18e6e 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 30, 2022
@sweeneyde
Copy link
MemberAuthor

Result:

AssertionError: 13 != 2 : [b"<string>:3: EncodingWarning: 'encoding' argument not specified.", b'Traceback (most recent call last):', b'  File "<string>", line 3, in <module>', b'  File "C:\\Workspace\\buildarea\\pull_request.linaro-win-arm64.nondebug\\build\\Lib\\subprocess.py", line 533, in run', b'    with Popen(*popenargs, **kwargs) as process:', b'         ^^^^^^^^^^^^^^^^^^^^^^^^^^^', b'  File "C:\\Workspace\\buildarea\\pull_request.linaro-win-arm64.nondebug\\build\\Lib\\subprocess.py", line 998, in __init__', b'    self._execute_child(args, executable, preexec_fn, close_fds,', b'    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^', b'  File "C:\\Workspace\\buildarea\\pull_request.linaro-win-arm64.nondebug\\build\\Lib\\subprocess.py", line 1467, in _execute_child', b'    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,', b'                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^', b'FileNotFoundError: [WinError 2] The system cannot find the file specified']

On multiple lines:

<string>:3: EncodingWarning: 'encoding' argument not specified.Traceback (most recent call last):  File "<string>", line 3, in <module>  File "C:\Workspace\buildarea\pull_request.linaro-win-arm64.nondebug\build\Lib\subprocess.py", line 533, in run    with Popen(*popenargs, **kwargs) as process:         ^^^^^^^^^^^^^^^^^^^^^^^^^^^  File "C:\Workspace\buildarea\pull_request.linaro-win-arm64.nondebug\build\Lib\subprocess.py", line 998, in __init__           self._execute_child(args, executable, preexec_fn, close_fds,    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File "C:\Workspace\buildarea\pull_request.linaro-win-arm64.nondebug\build\Lib\subprocess.py", line 1467, in _execute_child    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^FileNotFoundError: [WinError 2] The system cannot find the file specified

@methane

@sweeneydesweeneyde marked this pull request as ready for reviewApril 30, 2022 22:10
@sweeneydesweeneyde changed the titlegh-91954: test_subprocess.test_encoding_warning: Use stderr as the assertion messagegh-91954: Use shell=True in test_subprocess.test_encoding_warningApr 30, 2022
@sweeneydesweeneyde added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 30, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@sweeneyde for commit3453616 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 30, 2022
@sweeneydesweeneyde requested a review frommethaneApril 30, 2022 22:17
@sweeneyde
Copy link
MemberAuthor

Nice,ARM64 Windows Non-Debug PR is passing again.

Copy link
Member

@methanemethane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks.

@sweeneyde
Copy link
MemberAuthor

The failing "buildbot/AMD64 RHEL8 Refleaks PR" should be fixed by#92039

@sweeneydesweeneyde merged commitb963618 intopython:mainMay 1, 2022
@sweeneydesweeneyde deleted the encoding_warnings branchMay 1, 2022 00:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@methanemethanemethane approved these changes

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sweeneyde@bedevere-bot@methane
[8]ページ先頭
©2009-2025 Movatter.jp