Apr 30, 2022 · Apr 30, 2022 · Apr 30, 2022 · May 6, 2022 · May 6, 2022 · May 6, 2022
diff --git a/Modules/_datetimemodule.c b/Modules/_datetimemodule.c
    if (ns) {
        if (PyFloat_Check(ns)) {
            double ns_val = PyFloat_AsDouble(ns);
            leftover_ns += ns_val;
        } else {
            leftover_ns += PyLong_AsLong(ns);
        }
    if (leftover_us) {
        long integral_us = (long)leftover_us;
        // TODO: should use py_round; previous rounding was also wrong as it checks for x_is_odd instead of x + whole_us
        leftover_ns = round((leftover_us - integral_us) * 1000);
        if (leftover_ns > 999) {
            integral_us++;
            leftover_ns -= 1000;

        /* Copy the data we have */
        memcpy(me->data, pdata, data_size);


        /* If we don't have nanoseconds in the pickled data, initialize them to 0 */
        if (data_size == _PyDateTime_OLD_TIME_DATASIZE) {
            me->data[6] = 0;
            me->data[7] = 0;
        }


        me->hashcode = -1;
        me->hastzinfo = aware;
        if (aware) {

        /* Copy the data we have */
        memcpy(me->data, pdata, data_size);


        /* If we don't have nanoseconds in the pickled data, initialize them to 0 */
        if (data_size == _PyDateTime_OLD_DATETIME_DATASIZE) {
            me->data[10] = 0;
            me->data[11] = 0;
        }


        me->hashcode = -1;
        me->hastzinfo = aware;
        if (aware) {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3188,7 +3188,7 @@
		if (ns) {
		if (PyFloat_Check(ns)) {
		double ns_val = PyFloat_AsDouble(ns);
		leftover_ns += ns_val;
Check warning on line 3191 in Modules/_datetimemodule.c View workflow job for this annotation GitHub Actions/ Windows / Build and test (arm64) `'+=': conversion from 'double' to 'float', possible loss of data [C:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]` Check warning on line 3191 in Modules/_datetimemodule.c View workflow job for this annotation GitHub Actions/ Windows (free-threading) / Build and test (arm64) `'+=': conversion from 'double' to 'float', possible loss of data [C:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]` Check warning on line 3191 in Modules/_datetimemodule.c View workflow job for this annotation GitHub Actions/ Windows / Build and test (x64) `'+=': conversion from 'double' to 'float', possible loss of data [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]` Check warning on line 3191 in Modules/_datetimemodule.c View workflow job for this annotation GitHub Actions/ Windows (free-threading) / Build and test (x64) `'+=': conversion from 'double' to 'float', possible loss of data [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]`
		} else {
		leftover_ns += PyLong_AsLong(ns);
		}
Expand All		@@ -3196,7 +3196,7 @@
		if (leftover_us) {
		long integral_us = (long)leftover_us;
		// TODO: should use py_round; previous rounding was also wrong as it checks for x_is_odd instead of x + whole_us
		leftover_ns = round((leftover_us - integral_us) * 1000);
Check warning on line 3199 in Modules/_datetimemodule.c View workflow job for this annotation GitHub Actions/ Windows / Build and test (arm64) `'=': conversion from 'double' to 'float', possible loss of data [C:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]` Check warning on line 3199 in Modules/_datetimemodule.c View workflow job for this annotation GitHub Actions/ Windows (free-threading) / Build and test (arm64) `'=': conversion from 'double' to 'float', possible loss of data [C:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]` Check warning on line 3199 in Modules/_datetimemodule.c View workflow job for this annotation GitHub Actions/ Windows / Build and test (x64) `'=': conversion from 'double' to 'float', possible loss of data [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]` Check warning on line 3199 in Modules/_datetimemodule.c View workflow job for this annotation GitHub Actions/ Windows (free-threading) / Build and test (x64) `'=': conversion from 'double' to 'float', possible loss of data [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]`
		if (leftover_ns > 999) {
		integral_us++;
		leftover_ns -= 1000;
Expand DownExpand Up		@@ -4978,13 +4978,13 @@

		/* Copy the data we have */
		memcpy(me->data, pdata, data_size);


		/* If we don't have nanoseconds in the pickled data, initialize them to 0 */
		if (data_size == _PyDateTime_OLD_TIME_DATASIZE) {
		me->data[6] = 0;
		me->data[7] = 0;
		}


		me->hashcode = -1;
		me->hastzinfo = aware;
		if (aware) {
Expand DownExpand Up		@@ -5741,13 +5741,13 @@

		/* Copy the data we have */
		memcpy(me->data, pdata, data_size);


		/* If we don't have nanoseconds in the pickled data, initialize them to 0 */
		if (data_size == _PyDateTime_OLD_DATETIME_DATASIZE) {
		me->data[10] = 0;
		me->data[11] = 0;
		}


		me->hashcode = -1;
		me->hastzinfo = aware;
		if (aware) {
Expand Down