Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-92062:inspect.Parameter checks whethername is a keyword#92065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Zac-HD
Copy link
Contributor

@Zac-HDZac-HD commentedApr 30, 2022
edited by miss-islington
Loading

Fixes#92062.

Automerge-Triggered-By: GH:pganssle

@AlexWaygoodAlexWaygood added type-featureA feature request or enhancement stdlibStandard Library Python modules in the Lib/ directory labelsApr 30, 2022
@Zac-HD
Copy link
ContributorAuthor

I just can't understand whymake patchcheck is complaining about whitespace ininspect.py 😕

@JelleZijlstra
Copy link
Member

I just can't understand whymake patchcheck is complaining about whitespace ininspect.py 😕

There is some pre-existing trailing whitespace in the file (around lines 1648 and 1686).make patchcheck runs only on changed files and we don't have a check to make sure it passes on unchanged files (sorry for that). You should probably just fix the trailing whitespace.

Zac-HD reacted with thumbs up emoji

Jelle pointed out that this might occur in C functions, and so to avoid breaking any existing (if strange) code we'll only check params which can be called with named arguments.
@Zac-HD
Copy link
ContributorAuthor

Zac-HD commentedApr 30, 2022
edited
Loading

Oh, easy to fix now that I know what's happening! Thanks for the quick response 🤩

(Perhaps thepatchcheck job could also run agit diff so that contributors can see the problem?)

@miss-islingtonmiss-islington merged commit65f88a6 intopython:mainMay 3, 2022
@Zac-HDZac-HD deleted the zac-hd/error-on-keyword-params branchMay 3, 2022 20:52
@pganssle
Copy link
Member

This seems like it should be uncontroversial enough (famous last words — I'm sure someone is going to show up complaining that they use invalid signature objects as some load-bearing part of their workflow).

@Ark-kun
Copy link

I'm sure someone is going to show up complaining that they use invalid signature objects as some load-bearing part of their workflow

Sorry for making you wait so long.

So, for many years we were dynamically generating functions based on interface described in YAML files. With Python 3.9 our tests started to fail. Turns out we had some cases where a parameter with namein was being generated. I wonder whether the actual generated low-level functions worked in this case.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pgansslepgansslepganssle approved these changes

Assignees

No one assigned

Labels

stdlibStandard Library Python modules in the Lib/ directorytype-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

inspect.Parameter checks thatname is an identifier, but does not check for keywords

7 participants

@Zac-HD@JelleZijlstra@pganssle@Ark-kun@bedevere-bot@miss-islington@AlexWaygood

[8]ページ先頭

©2009-2025 Movatter.jp