Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
gh-92031: Deoptimize Static Code at Finalization#92039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bedevere-bot commentedApr 29, 2022
🤖 New build scheduled with the buildbot fleet by@sweeneyde for commitdf424cf 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
sweeneyde commentedApr 29, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
One remark: this will convert EXTENDED_ARG_QUICK to EXTENDED_ARG for subsequent interpreters using this code, even though EXTENDED_ARG_QUICK is the one emitted by the compiler. We should probably add a case for
The central issue is that |
Uh oh!
There was an error while loading.Please reload this page.
markshannon commentedMay 2, 2022
Feel free to add another table, they are only 256 bytes. |
bedevere-bot commentedMay 2, 2022
🤖 New build scheduled with the buildbot fleet by@sweeneyde for commitad9a38a 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
sweeneyde commentedMay 3, 2022
@markshannon is this okay to merge now? |
markshannon commentedMay 3, 2022
Yes it is |
vstinner commentedMay 4, 2022
test_repeated_init_exec() already repeats the code 4 times. What is the point of repeating the test 50 x 4 = 200 times? |
sweeneyde commentedMay 4, 2022
The failure was still intermittent when I tried it, and just 4 runs only made the test fail about 10-15% of the time when I measured. |
vstinner commentedMay 5, 2022
The Python test suite is run many times per day on each CI job and we have tons of CI jobs. IMO there is no need to loop so many tests inside the test. On buildbots, it's very common that bugs which is barely possible to trigger manually when I really want to reproduce them... fail all the time on a specific worker because each worker has different timings and a different operating system ;-) |
Uh oh!
There was an error while loading.Please reload this page.
#92031
TODO: