Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-91760: More strict rules for numerical group references and group names in RE#91792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 10 commits intopython:mainfromserhiy-storchaka:re-group-name
May 8, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedApr 21, 2022•
edited
Loading

Only sequence of ASCII digitsnot starting with 0 (except group 0) is
now accepted as a numerical reference.
The group name in bytes patterns and replacement strings can now only
contain ASCII letters and digits and underscore.

Closes#91760.

…group names in REOnly sequence of ASCII digits not starting with 0 (except group 0) isnow accepted as a numerical reference.The group name in bytes patterns and replacement strings can now onlycontain ASCII letters and digits and underscore.
Copy link
Member

@ezio-melottiezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm also not sure about forbidding the leading0, since it feels like a special case that only makes things more complicated and inconsistent with other implementations.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

Copy link
MemberAuthor

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR adds restrictions without deprecation. See also#91794.

@serhiy-storchaka
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

Copy link
Member

@ezio-melottiezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Are you still planning to add a deprecation warning?

@serhiy-storchaka
Copy link
MemberAuthor

See#91794.

ezio-melotti reacted with thumbs up emoji

@serhiy-storchakaserhiy-storchaka marked this pull request as draftApril 30, 2022 10:30
@serhiy-storchakaserhiy-storchaka added the type-featureA feature request or enhancement labelApr 30, 2022
@serhiy-storchakaserhiy-storchaka marked this pull request as ready for reviewMay 8, 2022 16:06
@serhiy-storchakaserhiy-storchaka merged commita84a56d intopython:mainMay 8, 2022
@serhiy-storchakaserhiy-storchaka deleted the re-group-name branchMay 8, 2022 16:19
@ooliver1
Copy link

What's that DO-NOT-MERGE label for

@serhiy-storchaka
Copy link
MemberAuthor

Oh, I forget to remove it.

It meant that the PR should not be merged by accident in 3.11.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ezio-melottiezio-melottiezio-melotti approved these changes

Assignees
No one assigned
Labels
topic-regextype-featureA feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More strict rules for group numbers and names in RE
4 participants
@serhiy-storchaka@bedevere-bot@ooliver1@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp