Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-91583: AC: Fix regression for functions with defining_class#91739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@serhiy-storchaka
Copy link
Member

Argument Clinic now generates the same efficient code as before
adding the defining_class parameter.

Closes#91583.

Argument Clinic now generates the same efficient code as beforeadding the defining_class parameter.
@serhiy-storchakaserhiy-storchaka merged commita055dac intopython:mainApr 30, 2022
@miss-islington
Copy link
Contributor

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker a055dac0b45031878a8196a8735522de018491e3 3.10

@miss-islington
Copy link
Contributor

Sorry@serhiy-storchaka, I had trouble checking out the3.9 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker a055dac0b45031878a8196a8735522de018491e3 3.9

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestApr 30, 2022
…_class (pythonGH-91739)Argument Clinic now generates the same efficient code as beforeadding the defining_class parameter..(cherry picked from commita055dac)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestApr 30, 2022
…class (pythonGH-91739)Argument Clinic now generates the same efficient code as beforeadding the defining_class parameter..(cherry picked from commita055dac)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-92079 is a backport of this pull request to the3.10 branch.

@bedevere-bot
Copy link

GH-92080 is a backport of this pull request to the3.9 branch.

@erlend-aasland
Copy link
Contributor

erlend-aasland commentedApr 30, 2022•
edited
Loading

I started to review this PR, but I never got around to finish the review. Idid take a good and long look1 at the changes; they make sense, and I did not find any issues. So, approved post merge :)

Thanks for doing this, Serhiy!

Footnotes

  1. it took me several days, as I was not familiar with howclinic.py actually worked↩

@serhiy-storchakaserhiy-storchaka deleted the clinic-defining_class branchApril 30, 2022 13:57
@serhiy-storchaka
Copy link
MemberAuthor

Well, I don't think anyone has a complete picture in their head right now. At least not for a long time.

erlend-aasland reacted with laugh emoji

serhiy-storchaka added a commit that referenced this pull requestMay 3, 2022
…GH-91739) (GH-92079)Argument Clinic now generates the same efficient code as beforeadding the defining_class parameter.(cherry picked from commita055dac)
serhiy-storchaka added a commit that referenced this pull requestMay 3, 2022
…H-91739) (GH-92080)Argument Clinic now generates the same efficient code as beforeadding the defining_class parameter.(cherry picked from commita055dac)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull requestJun 2, 2022
…class (pythonGH-91739) (pythonGH-92080)Argument Clinic now generates the same efficient code as beforeadding the defining_class parameter.(cherry picked from commita055dac)
@serhiy-storchakaserhiy-storchaka removed their assignmentJun 21, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rhettingerrhettingerAwaiting requested review from rhettinger

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

@tirantiranAwaiting requested review from tiran

Assignees

No one assigned

Labels

performancePerformance or resource usagetopic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression in the AC generated code

5 participants

@serhiy-storchaka@miss-islington@bedevere-bot@erlend-aasland@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp