Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-91632: Fix generic_alias_iterator to be finalized at exit.#91727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c7d5777 to39886d9CompareFidget-Spinner commentedApr 20, 2022
I can't review this since I have no clue on the process of freeing memory on exit. But when do we add a type to |
Uh oh!
There was an error while loading.Please reload this page.
vstinner commentedApr 20, 2022
I propose two approaches:
|
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Misc/NEWS.d/next/Core and Builtins/2022-04-20-14-43-37.gh-issue-91632.cvUhsZ.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…e-91632.cvUhsZ.rstCo-authored-by: Victor Stinner <vstinner@python.org>
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
JelleZijlstra commentedApr 20, 2022
Should this be backported? |
Fidget-Spinner commentedApr 20, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@JelleZijlstra No. Generic alias iterator is part of the variadic generics PEP which is 3.11 only iirc. |
vstinner commentedApr 20, 2022
The work to clear static types at exit is new in Python 3.11 (especially the _PyTypes_FiniTypes() function). |
Uh oh!
There was an error while loading.Please reload this page.
AS-IS
TO-BE
Follow Victor's suggestion :)
closes:#91632