Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-91432: Specialize FOR_ITER#91713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
markshannon merged 44 commits intopython:mainfromsweeneyde:special_for_iter2
Jun 21, 2022
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
44 commits
Select commitHold shift + click to select a range
3a7f8df
initial attempt
sweeneydeApr 17, 2022
3b5ce1e
bump magic
sweeneydeApr 17, 2022
b21b5f4
Merge remote-tracking branch 'upstream/main' into special_for_iter2
sweeneydeApr 18, 2022
37269cf
NOTRACE_DISPATCH_SAME_OPARG
sweeneydeApr 18, 2022
ea0a7ee
Update mark_stacks
sweeneydeApr 18, 2022
0751228
comment out assertions
sweeneydeApr 19, 2022
dc80fda
Merge branch 'main' into special_for_iter2
sweeneydeApr 19, 2022
e429410
Make FOR_ITER_RANGE mutate the local
sweeneydeApr 19, 2022
1cb2de7
Merge remote-tracking branch 'upstream/main' into special_for_iter2
sweeneydeApr 19, 2022
73fa01c
Fix overflow
sweeneydeApr 19, 2022
4213582
fix test
sweeneydeApr 19, 2022
bf58358
fix dis
sweeneydeApr 19, 2022
bd7575e
Add more tests, add more casts
sweeneydeApr 19, 2022
db8754b
Merge branch 'main' into special_for_iter2
sweeneydeApr 20, 2022
2050c4e
merge with main
sweeneydeApr 24, 2022
824e966
Fix stats, take out some PREDICT
sweeneydeApr 24, 2022
6b16772
📜🤖 Added by blurb_it.
blurb-it[bot]Apr 24, 2022
c2a75a5
merge with main
sweeneydeApr 28, 2022
6696384
remove PREDEICTED(STORE_FAST)
sweeneydeApr 28, 2022
d297091
assert no tracing
sweeneydeApr 28, 2022
22635a6
Merge branch 'special_for_iter2' of https://github.com/sweeneyde/cpyt…
sweeneydeApr 28, 2022
f360d65
remove unnecessary cast
sweeneydeApr 28, 2022
81e0500
merge with main
sweeneydeMay 3, 2022
c2eab68
regen
sweeneydeMay 3, 2022
25689c3
merge and bump magic
sweeneydeMay 4, 2022
b5df047
merge with main
sweeneydeMay 8, 2022
2b1c170
Merge remote-tracking branch 'upstream/main' into special_for_iter2
sweeneydeMay 10, 2022
91d280c
Fix test_dis
sweeneydeMay 10, 2022
eba5e60
merge with main
sweeneydeMay 12, 2022
5b153d7
Merge branch 'main' into special_for_iter2
sweeneydeMay 12, 2022
76f9a74
merge with main
sweeneydeMay 20, 2022
0565a68
Merge branch 'special_for_iter2' of https://github.com/sweeneyde/cpyt…
sweeneydeMay 20, 2022
9ba5b79
merge with main
sweeneydeJun 9, 2022
6cdf0e4
Add comment about re-using the old PyLongObject
sweeneydeJun 9, 2022
03dde6a
Merge branch 'main' of https://github.com/python/cpython into special…
sweeneydeJun 10, 2022
f1e2d39
update test_dis.py
sweeneydeJun 10, 2022
463c3b9
Merge remote-tracking branch 'upstream/main' into special_for_iter2
sweeneydeJun 14, 2022
ed29777
use the new exponential backoff
sweeneydeJun 14, 2022
188b357
merge with main
sweeneydeJun 18, 2022
36d0999
revert using sdigits, add _PyLong_AssignValue
sweeneydeJun 19, 2022
ad2e969
revert test_sys sizeof check
sweeneydeJun 19, 2022
d55868f
revert test_range changes
sweeneydeJun 19, 2022
2d6ee26
add comment and use Py_ssize_t
sweeneydeJun 20, 2022
db21da1
Add comment: only positive
sweeneydeJun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Add more tests, add more casts
  • Loading branch information
@sweeneyde
sweeneyde committedApr 19, 2022
commitbd7575e495860e420bef7e9692f1eda7ea39ee66
9 changes: 5 additions & 4 deletionsLib/test/test_range.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -507,7 +507,7 @@ def test_range_iterators(self):
# exercise 'fast' iterators, that use a rangeiterobject internally.
# see issue 7298
limits = [base + jiggle
for M in (2**32, 2**64)
for M in (2**15, 2**30, 2**32, 2**64)
for base in (-M, -M//2, 0, M//2, M)
for jiggle in (-2, -1, 0, 1, 2)]
test_ranges = [(start, end, step)
Expand All@@ -519,13 +519,14 @@ def test_range_iterators(self):
iter1 = range(start, end, step)
iter2 = pyrange(start, end, step)
test_id = "range({}, {}, {})".format(start, end, step)
# check first100 entries
self.assert_iterators_equal(iter1, iter2, test_id, limit=100)
# check first10 entries
self.assert_iterators_equal(iter1, iter2, test_id, limit=10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why reduce from 100 to 10?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I made it 4x slower otherwise by doubling the number ofM values, and it started to feel a bit sluggish, so I wanted to offset that.


iter1 = reversed(range(start, end, step))
iter2 = pyrange_reversed(start, end, step)
test_id = "reversed(range({}, {}, {}))".format(start, end, step)
self.assert_iterators_equal(iter1, iter2, test_id, limit=100)
self.assert_iterators_equal(iter1, iter2, test_id, limit=10)


def test_range_iterators_invocation(self):
# verify range iterators instances cannot be created by
Expand Down
16 changes: 8 additions & 8 deletionsObjects/rangeobject.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1097,10 +1097,10 @@ range_iter(PyObject *seq)
goto long_range;
}
ulen = get_len_of_range(lstart, lstop, lstep);
if (ulen > PyLong_MASK ||
lstart > PyLong_MASK || lstart < -(long)PyLong_MASK ||
lstop > PyLong_MASK || lstop < -(long)PyLong_MASK ||
lstep > PyLong_MASK || lstep < -(long)PyLong_MASK)
if (ulen >(long)PyLong_MASK ||
lstart >(long)PyLong_MASK || lstart < -(long)PyLong_MASK ||
lstop >(long)PyLong_MASK || lstop < -(long)PyLong_MASK ||
lstep >(long)PyLong_MASK || lstep < -(long)PyLong_MASK)
{
goto long_range;
}
Expand DownExpand Up@@ -1190,10 +1190,10 @@ range_reverse(PyObject *seq, PyObject *Py_UNUSED(ignored))

new_stop = lstart - lstep;
new_start = (long)(new_stop + ulen * lstep);
if (ulen > PyLong_MASK ||
new_start > PyLong_MASK || new_start < -(long)PyLong_MASK ||
new_stop > PyLong_MASK || new_stop < -(long)PyLong_MASK ||
lstep > PyLong_MASK || lstep < -(long)PyLong_MASK)
if (ulen >(long)PyLong_MASK ||
new_start >(long)PyLong_MASK || new_start < -(long)PyLong_MASK ||
new_stop >(long)PyLong_MASK || new_stop < -(long)PyLong_MASK ||
lstep >(long)PyLong_MASK || lstep < -(long)PyLong_MASK)
{
goto long_range;
}
Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp