Jun 21, 2022 · Apr 17, 2022 · Apr 17, 2022 · Apr 18, 2022 · Apr 18, 2022 · Apr 18, 2022
diff --git a/Include/internal/pycore_long.h b/Include/internal/pycore_long.h
 PyObject *_PyLong_Multiply(PyLongObject *left, PyLongObject *right);
 PyObject *_PyLong_Subtract(PyLongObject *left, PyLongObject *right);

 int _PyLong_AssignValue(PyObject **target,long value);
 int _PyLong_AssignValue(PyObject **target,Py_ssize_t value);

 /* Used by Python/mystrtoul.c, _PyBytes_FromHex(),
   _PyBytes_DecodeEscape(), etc. */
diff --git a/Objects/longobject.c b/Objects/longobject.c
 }

 int
 _PyLong_AssignValue(PyObject **target,long value)
 _PyLong_AssignValue(PyObject **target,Py_ssize_t value)
 {
    PyObject *old = *target;
    if (IS_SMALL_INT(value)) {
        *target = get_small_int(Py_SAFE_DOWNCAST(value,long, sdigit));
        *target = get_small_int(Py_SAFE_DOWNCAST(value,Py_ssize_t, sdigit));
        Py_XDECREF(old);
        return 0;
    }
    else if (old != NULL && PyLong_CheckExact(old) &&
             Py_REFCNT(old) == 1 && Py_SIZE(old) == 1 &&
             (unsigned long)value <= PyLong_MASK)
             (size_t)value <= PyLong_MASK)
    {
        // Mutate in place if there are no other references to the old object.
        // This avoids an allocation in a common case.
        ((PyLongObject *)old)->ob_digit[0]
            = Py_SAFE_DOWNCAST(value,long, digit);
            = Py_SAFE_DOWNCAST(value,Py_ssize_t, digit);
        return 0;
    }
    else {
        *target =PyLong_FromLong(value);
        *target =PyLong_FromSsize_t(value);
        Py_XDECREF(old);
        if (*target == NULL) {
            return -1;
diff --git a/Python/ceval.c b/Python/ceval.c
            if (_PyLong_AssignValue(&GETLOCAL(_Py_OPARG(next)), value) < 0) {
                goto error;
            }
            // The STORE_FAST is already done.
            JUMPBY(INLINE_CACHE_ENTRIES_FOR_ITER + 1);
            NOTRACE_DISPATCH();
        }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -47,7 +47,7 @@ PyObject _PyLong_Add(PyLongObject left, PyLongObject *right);
		PyObject _PyLong_Multiply(PyLongObject left, PyLongObject *right);
		PyObject _PyLong_Subtract(PyLongObject left, PyLongObject *right);

		int _PyLong_AssignValue(PyObject **target,long value);
		int _PyLong_AssignValue(PyObject **target,Py_ssize_t value);

		/* Used by Python/mystrtoul.c, _PyBytes_FromHex(),
		_PyBytes_DecodeEscape(), etc. */
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -263,26 +263,26 @@ _PyLong_FromSTwoDigits(stwodigits x)
		}

		int
		_PyLong_AssignValue(PyObject **target,long value)
		_PyLong_AssignValue(PyObject **target,Py_ssize_t value)
		{
		PyObject old = target;
		if (IS_SMALL_INT(value)) {
		*target = get_small_int(Py_SAFE_DOWNCAST(value,long, sdigit));
		*target = get_small_int(Py_SAFE_DOWNCAST(value,Py_ssize_t, sdigit));
		Py_XDECREF(old);
		return 0;
		}
		else if (old != NULL && PyLong_CheckExact(old) &&
Copy link Member markshannonJun 20, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This only works for positive integers. Given that it is only used for`range` iteration, that's fine for now. But could you add a comment, so it doesn't get overlooked when we implementfaster-cpython/ideas#147
		Py_REFCNT(old) == 1 && Py_SIZE(old) == 1 &&
		(unsigned long)value <= PyLong_MASK)
		(size_t)value <= PyLong_MASK)
		{
		// Mutate in place if there are no other references to the old object.
		// This avoids an allocation in a common case.
		((PyLongObject *)old)->ob_digit[0]
		= Py_SAFE_DOWNCAST(value,long, digit);
		= Py_SAFE_DOWNCAST(value,Py_ssize_t, digit);
		return 0;
		}
		else {
		*target =PyLong_FromLong(value);
		*target =PyLong_FromSsize_t(value);
		Py_XDECREF(old);
		if (*target == NULL) {
		return -1;
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4510,6 +4510,7 @@ _PyEval_EvalFrameDefault(PyThreadState tstate, _PyInterpreterFrame frame, int
		if (_PyLong_AssignValue(&GETLOCAL(_Py_OPARG(next)), value) < 0) {
		goto error;
		}
		// The STORE_FAST is already done.
		JUMPBY(INLINE_CACHE_ENTRIES_FOR_ITER + 1);
Copy link Member markshannonJun 20, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Could you add a comment explaining why this is`INLINE_CACHE_ENTRIES_FOR_ITER + 1` rather than just`INLINE_CACHE_ENTRIES_FOR_ITER`.
		NOTRACE_DISPATCH();
		}
Expand Down