Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
[3.9] [3.10] gh-91607: Fix several test_concurrent_futures tests to actually test what they claim (GH-91600) (GH-91612)#91617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…s to actually test what they claim (pythonGH-91600) (pythonGH-91612)* Fix test_concurrent_futures to actually test what it says.Many ProcessPoolExecutor based tests were ignoring the mp_contextand using the default instead. This meant we lacked proper testcoverage of all of them.Also removes the old _prime_executor() worker delay seeding codeas it appears to have no point and causes 20-30 seconds extralatency on this already long test. It also interfered with someof the refactoring to fix the above to not needlessly create theirown executor when setUp has already created an appropriate one.* Don't import the name from multiprocessing directly to avoid confusion.(cherry picked from commit7fa3a5a)Co-authored-by: Gregory P. Smith <greg@krypto.org>.(cherry picked from commit9a45893)Co-authored-by: Gregory P. Smith <greg@krypto.org>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull requestJun 2, 2022
…s to actually test what they claim (pythonGH-91600) (pythonGH-91612) (python#91617)* Fix test_concurrent_futures to actually test what it says.Many ProcessPoolExecutor based tests were ignoring the mp_contextand using the default instead. This meant we lacked proper testcoverage of all of them.Also removes the old _prime_executor() worker delay seeding codeas it appears to have no point and causes 20-30 seconds extralatency on this already long test. It also interfered with someof the refactoring to fix the above to not needlessly create theirown executor when setUp has already created an appropriate one.* Don't import the name from multiprocessing directly to avoid confusion.(cherry picked from commit7fa3a5a)(cherry picked from commit9a45893)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many ProcessPoolExecutor based tests were ignoring the mp_context
and using the default instead. This meant we lacked proper test
coverage of all of them.
Also removes the old _prime_executor() worker delay seeding code
as it appears to have no point and causes 20-30 seconds extra
latency on this already long test. It also interfered with some
of the refactoring to fix the above to not needlessly create their
own executor when setUp has already created an appropriate one.
(cherry picked from commit7fa3a5a)
(cherry picked from commit9a45893)