NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

gh-69093: improve sqlite3.Connection.blobopen() error handling#91571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 1 commit intopython:mainfromerlend-aasland:sqlite-blob-misuse

Apr 15, 2022

Merged

gh-69093: improve sqlite3.Connection.blobopen() error handling#91571

JelleZijlstra merged 1 commit intopython:mainfromerlend-aasland:sqlite-blob-misuse

Apr 15, 2022

Conversation

Copy link

Contributor

erlend-aasland commentedApr 15, 2022•
edited
Loading

Unless sqlite3_blob_open() returns SQLITE_MISUSE, the error code and
message are available on the connection object. This means we have to
handle SQLITE_MISUSE error messages explicitly.

gh-69093

pythongh-69093: improve sqlite3.Connection.blobopen() error handling

a063b1c

Unless sqlite3_blob_open() returns SQLITE_MISUSE, the error code andmessage are available on the connection object. This means we have tohandle SQLITE_MISUSE error messages explicitly.

erlend-aasland requested a review fromberkerpeksag as acode owner

April 15, 2022 14:49

bedevere-bot added the awaiting review label

Apr 15, 2022

erlend-aasland requested a review fromJelleZijlstra

April 15, 2022 14:49

erlend-aasland added the skip news label

Apr 15, 2022

Copy link

ContributorAuthor

erlend-aasland commentedApr 15, 2022

I noticed this comment in thesqlite3_blob_open docs:

Unless it returns SQLITE_MISUSE, this function sets thedatabase connection error code and message accessible viasqlite3_errcode() andsqlite3_errmsg() and related functions.

_pysqlite_seterror uses the error code/message that is set on the connection object, so we need to handle theSQLITE_MISUSE case explicitly. Unfortunately (or luckily), there is no way for us to force such an error, so we cannot add a unit test for this.