Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-91502: Add a new API to check if a frame is an entry frame#91503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 1 commit intopython:mainfrompablogsal:bpo-91502
Apr 13, 2022

Conversation

@pablogsal
Copy link
Member

Closes:#91502

@markshannon
Copy link
Member

The concept of an entry frame is an implementation detail. Could you make it clearer that this is an unstable API?
Otherwise LGTM.

@pablogsal
Copy link
MemberAuthor

The concept of an entry frame is an implementation detail. Could you make it clearer that this is an unstable API?

I did that by adding a leading underscore (and not documenting the API), do you want me to add a note to the header file?

@markshannon
Copy link
Member

do you want me to add a note to the header file?

If you wouldn't mind, thanks.

@pablogsal
Copy link
MemberAuthor

I have added a message to the header explaining the situation and the contract 👍

@pablogsalpablogsal merged commit37a53fb intopython:mainApr 13, 2022
@pablogsalpablogsal deleted the bpo-91502 branchApril 13, 2022 13:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@brandtbucherbrandtbucherAwaiting requested review from brandtbucher

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow tools to check if a frame is an entry frame

3 participants

@pablogsal@markshannon@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp