Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-34426: Fix typo in Misc/SpecialBuilds.txt#8822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Mariatta merged 1 commit intopython:masterfromdanishprakash:fix-issue-34426
Aug 25, 2018

Conversation

@danishprakash
Copy link
Contributor

@danishprakashdanishprakash commentedAug 19, 2018
edited by bedevere-bot
Loading

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@pablogsal
Copy link
Member

Hi @prakashdanish and thank you for your contribution. Some things here:

  1. You made your PR against the 3.6 branch. Please, direct the PR against the current master and we will backport this if needed.

  2. You need to sign the CLA first.

@danishprakash
Copy link
ContributorAuthor

Hi@pablogsal

  1. I branched out my local branch from 3.6, might as well open a new PR for this.

  2. I've already signed the CLA yesterday, not sure what's holding it up.

@pablogsal
Copy link
Member

@prakashdanish Please, branch out from current master and direct the PR against that as statedhere.

@danishprakashdanishprakash changed the base branch from3.6 tomasterAugust 20, 2018 05:30
@danishprakash
Copy link
ContributorAuthor

@pablogsal could you look at this again?

@berkerpeksagberkerpeksag changed the titlebpo-34426: fix variable name inLLTRACE sectionbpo-34426: Fix typo in Misc/SpecialBuilds.txtAug 23, 2018
@berkerpeksag
Copy link
Member

@prakashdanish please rebase your branch. It looks like AppVeyor and Bedevere didn't notice the base branch change you've made. They may notice the push event.

@MariattaMariatta merged commit09efe49 intopython:masterAug 25, 2018
@miss-islington
Copy link
Contributor

Thanks @prakashdanish for the PR, and@Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 25, 2018
(cherry picked from commit09efe49)Co-authored-by: Danish Prakash <grafitykoncept@gmail.com>
@bedevere-bot
Copy link

GH-8915 is a backport of this pull request to the3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 25, 2018
(cherry picked from commit09efe49)Co-authored-by: Danish Prakash <grafitykoncept@gmail.com>
@bedevere-bot
Copy link

GH-8916 is a backport of this pull request to the3.6 branch.

@Mariatta
Copy link
Member

Thanks @prakashdanish and congrats on your first contribution to CPython 🌮

danishprakash reacted with thumbs up emoji

@danishprakash
Copy link
ContributorAuthor

@Mariatta wow, been reading your posts lately, thanks for the heads up! Looking forward to being a regular contributor.

miss-islington added a commit that referenced this pull requestAug 25, 2018
(cherry picked from commit09efe49)Co-authored-by: Danish Prakash <grafitykoncept@gmail.com>
Mariatta pushed a commit that referenced this pull requestAug 25, 2018
(cherry picked from commit09efe49)Co-authored-by: Danish Prakash <grafitykoncept@gmail.com>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull requestAug 27, 2018
* master: (104 commits)  Fast path for exact floats in math.hypot() and math.dist() (pythonGH-8949)  Remove AIX workaround test_subprocess (pythonGH-8939)  bpo-34503: Fix refleak in PyErr_SetObject() (pythonGH-8934)  closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (pythonGH-8935)  closes bpo-34501: PyType_FromSpecWithBases: Check spec->name before dereferencing it. (pythonGH-8930)  closes bpo-34502: Remove a note about utf8_mode from sys.exit() docs. (pythonGH-8928)  Remove unneeded PyErr_Clear() in _winapi_SetNamedPipeHandleState_impl() (pythonGH-8281)  Fix markup in stdtypes documentation (pythonGH-8905)  bpo-34395: Don't free allocated memory on realloc fail in load_mark() in _pickle.c. (pythonGH-8788)  Fix upsizing of marks stack in pickle module. (pythonGH-8860)  bpo-34171: Prevent creating Lib/trace.cover when run the trace module. (pythonGH-8841)  closes bpo-34493: Objects/genobject.c: Add missing NULL check to compute_cr_origin() (pythonGH-8911)  Fixed typo with asynccontextmanager code example (pythonGH-8845)  bpo-34426: fix typo (__lltrace__ -> __ltrace__) (pythonGH-8822)  bpo-13312: Avoid int underflow in time year. (pythonGH-8912)  bpo-34492: Python/coreconfig.c: Fix _Py_wstrlist_copy() (pythonGH-8910)  bpo-34448: Improve output of usable wchar_t check (pythonGH-8846)  closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (pythonGH-8869)  bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks (pythonGH-8864)  Fix typo in the dataclasses's doc (pythonGH-8896)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@MariattaMariattaMariatta approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@danishprakash@the-knights-who-say-ni@pablogsal@berkerpeksag@miss-islington@bedevere-bot@Mariatta

[8]ページ先頭

©2009-2025 Movatter.jp