Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-34392: Add sys. _is_interned()#8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedAug 13, 2018•
edited
Loading

sys_isinterned_impl(PyObject *module, PyObject *string)
/*[clinic end generated code: output=0364c3f36499f868 input=2fe09bef8edf732e]*/
{
return PyUnicode_CHECK_INTERNED(string);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Question: Currentlysys.internmakes aPyUnicode_CheckExact(s) over the string so interning a subclass of a string gives aTypeError back. This returnsFalse. Does it make sense to do a exact check to mirror the interface ofsys.intern?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't know.

@csabella
Copy link
Contributor

@methane, should this be merged after fixing the merge conflicts? Thanks!

@methanemethane changed the titlebpo-34392: Add sys.isinterned().bpo-34392: Add sys. _is_interned()May 26, 2020
@methane
Copy link
Member

@methane, should this be merged after fixing the merge conflicts? Thanks!

Up to@serhiy-storchaka. He wanted this API to write some tests.

…92.9kIlMF.rstCo-authored-by: Inada Naoki <songofacandy@gmail.com>
Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@serhiy-storchaka
Copy link
MemberAuthor

I have made the requested changes; please review again.

@serhiy-storchakaserhiy-storchaka dismissediritkatriel’sstale reviewDecember 4, 2023 09:06

Merge conflicts are resolved.

@serhiy-storchakaserhiy-storchaka merged commitdee7bee intopython:mainDec 4, 2023
@serhiy-storchakaserhiy-storchaka deleted the sys-isinterned branchDecember 4, 2023 09:09
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@methanemethanemethane approved these changes

@pablogsalpablogsalpablogsal left review comments

@iritkatrieliritkatrieliritkatriel left review comments

Assignees
No one assigned
Labels
type-featureA feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@serhiy-storchaka@csabella@methane@bedevere-bot@iritkatriel@pablogsal@the-knights-who-say-ni@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp